Open lanitochka17 opened 1 week ago
Triggered auto assignment to @sonialiap (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
@sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Job added to Upwork: https://www.upwork.com/jobs/~021842185001478860112
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External
)
Form navigates to first step on refresh
There are actually 2 bug in the flow:
So even if we fix 1, there would be a regression that values won't be saved once refreshed. So we need to fix both the bugs here.
Like the refactor we did in :
We need to refactor the full form to save draft values of the form as well as save the current state of the form (sub-step) using the util getInitialSubstep
. We would also need to refactor NetSuiteImportAddCustomSegmentPage
as both use the same substeps. and also update any similar places where this bug exists
[!NOTE] The scope of work is vast as this would be full form refactor i.e. adding
draft states
toOnyx
, adding draft values to FORM input of bothNetSuiteImportAddCustomSegmentPage
andNetSuiteImportAddCustomListPage
, creating new utils, changing the form structure completely, creating related types files. So i think that for this issue a fair compensation would be $750 considering the amount of work involved
@sonialiap, @rayane-djouah Whoops! This issue is 2 days overdue. Let's get this updated quick!
@allgandalf's proposal looks good to me
:ribbon::eyes::ribbon: C+ reviewed
Triggered auto assignment to @danieldoglas, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
thanks @rayane-djouah , @danieldoglas please take a look at the note, i have explained the scope of work and requested an increase in bounty, please consider that request 😄
I agree that a payment increase would be fair given the scope of work
bump @danieldoglas for assignment
I missed this issue, my bad. I've read the proposal and I initially agree with it, but I'll refer to @yuwenmemon since he was one of the people working on this functionality before moving on.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.42-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester+shsb22tet1122@applause.expensifail.com Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
App stays in the current flow ("How should this custom list be displayed in Expensify?")
Actual Result:
App navigates to the first step of the flow ("Choose a custom list" step)
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/user-attachments/assets/7ae9a867-ea6e-47f9-b669-c965e017dd74
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @rayane-djouah