Open lanitochka17 opened 1 month ago
Triggered auto assignment to @NikkiWines (DeployBlockerCash
), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
:wave: Friendly reminder that deploy blockers are time-sensitive โฑ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Small excerpt from the logs that indicates ANR due to input dispatching timing out
10-01 16:22:55.226 1690 2311 I WindowManager: ANR in Window{7039d05 u0 com.expensify.chat/com.expensify.chat.MainActivity}. Reason:Input dispatching timed out (7039d05 com.expensify.chat/com.expensify.chat.MainActivity (server) is not responding. Waited 5002ms for MotionEvent).
10-01 16:22:58.910 1690 10452 D CoreBackPreview: startBackNavigation currentTask=Task{cf8a51d #1405 type=standard A=10374:com.expensify.chat}, topRunningActivity=ActivityRecord{f262be1 u0 com.expensify.chat/.MainActivity t1405}, callbackInfo=OnBackInvokedCallbackInfo{mCallback=android.window.IOnBackInvokedCallback$Stub$Proxy@7ddb39e, mPriority=0, mIsAnimationCallback=false}, currentFocus=Window{7039d05 u0 com.expensify.chat/com.expensify.chat.MainActivity}
10-01 16:22:59.323 1690 10444 D CoreBackPreview: startBackNavigation currentTask=Task{cf8a51d #1405 type=standard A=10374:com.expensify.chat}, topRunningActivity=ActivityRecord{f262be1 u0 com.expensify.chat/.MainActivity t1405}, callbackInfo=OnBackInvokedCallbackInfo{mCallback=android.window.IOnBackInvokedCallback$Stub$Proxy@7ddb39e, mPriority=0, mIsAnimationCallback=false}, currentFocus=Window{7039d05 u0 com.expensify.chat/com.expensify.chat.MainActivity}
10-01 16:22:59.513 1690 8519 E ActivityManager: ANR in com.expensify.chat (com.expensify.chat/.MainActivity)
10-01 16:22:59.513 1690 8519 E ActivityManager: Reason: Input dispatching timed out (7039d05 com.expensify.chat/com.expensify.chat.MainActivity (server) is not responding. Waited 5002ms for MotionEvent).
10-01 16:22:59.513 1690 8519 E ActivityManager: Parent: com.expensify.chat/.MainActivity
10-01 16:22:59.513 1690 8519 E ActivityManager: 70% 5849/com.expensify.chat: 62% user + 8.2% kernel / faults: 82391 minor 202 major
10-01 16:22:59.513 1690 8519 E ActivityManager: 16% 5849/com.expensify.chat: 8% user + 8% kernel / faults: 1078 minor 11 major
10-01 16:22:59.516 1690 8519 D ActivityManager: Completed ANR of com.expensify.chat in 4286ms, latency 2ms
10-01 16:22:59.551 1690 1742 D CoreBackPreview: Window{da372a9 u0 Application Not Responding: com.expensify.chat}: Setting back callback OnBackInvokedCallbackInfo{mCallback=android.window.WindowOnBackInvokedDispatcher$OnBackInvokedCallbackWrapper@8dcf3f4, mPriority=0, mIsAnimationCallback=false}
10-01 16:23:01.121 1690 10447 D CoreBackPreview: startBackNavigation currentTask=null, topRunningActivity=null, callbackInfo=OnBackInvokedCallbackInfo{mCallback=android.window.WindowOnBackInvokedDispatcher$OnBackInvokedCallbackWrapper@8dcf3f4, mPriority=0, mIsAnimationCallback=false}, currentFocus=Window{da372a9 u0 Application Not Responding: com.expensify.chat}
10-01 16:23:02.324 1690 1742 W ActivityTaskManager: Force finishing activity com.expensify.chat/.MainActivity
10-01 16:23:02.328 1690 1742 I ActivityManager: Killing 5849:com.expensify.chat/u0a374 (adj 200): user request after error
10-01 16:23:02.330 1690 1742 D CoreBackPreview: Window{da372a9 u0 Application Not Responding: com.expensify.chat}: Setting back callback null
10-01 16:23:02.467 1690 10443 I WindowManager: WIN DEATH: Window{7039d05 u0 com.expensify.chat/com.expensify.chat.MainActivity}
@lanitochka17 can we retest this with a few different actions (on staging and production please) - I'm trying to figure out which action specifically might be causing this
Retest One: Update only the description multiple times
Retest Two: Go to the description (but do not edit) multiple times
Retest 1: Reproducible (but it goes back on its own due to the other KI) so not exactly the same https://github.com/user-attachments/assets/5d0ffe5e-88c5-46ba-b85e-cb00c1e83fa7
Production Retest 2: Not reproducible https://github.com/user-attachments/assets/950d52b7-bb29-4413-af71-afca5084272b
Staging: Retest one reproducible https://github.com/user-attachments/assets/a327b7d4-453c-4a15-b8b8-e51184137b0e
Staging retest two not reproducible:
https://github.com/user-attachments/assets/63c01264-ecb3-41eb-9b62-f8624183428a
Ok, interesting. Thank you for retesting!! So it's more tied to the repeat title / description changes than it is to the navigation / reloading new views.
I'm going to re-review the deploy diff to see if anything we changed there might be impacting this, but let's open this up to External
to get more eyes on it. I'm not very familiar with Android specific logic so the more eyes the better ๐
Job added to Upwork: https://www.upwork.com/jobs/~021841233543234613924
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External
)
Issue is not reproducible anymore - Video below:
https://github.com/user-attachments/assets/e5eccfff-992c-4dc0-a4c4-911840734947
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
Nice ๐
Another tester that was reproducing at the same time was able to reproduce this one - the only difference between the 2 reproductions is the amount of edits the description field had. Imo this one looks like a edge case since it's not consistently reproducible.
Here's the video:
https://github.com/user-attachments/assets/6db68e55-1800-4bbd-969d-c66b89fce32b
It sounds like it's not worth blocking deploy on something that is not consistently reproducible and only appears on a single platform. I'll keep this issue open if we want to investigate further.
@NikkiWines, @jjcoffee Huh... This is 4 days overdue. Who can take care of this?
Triggered auto assignment to @adelekennedy (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
I got assigned https://github.com/Expensify/App/issues/50270, and it sounds like it's a dupe of this issue, so closing it in favor of this one. LMK if anyone disagrees with that!
@bernhardoj Feel free to post your proposal here!
๐ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐ธ
I'm interested in @bernhardoj's proposal from the other issue, would you mind posting it here?
One question I have is if this is happening in other places where SpacerView
is used?
I just tried reproducing this issue with my proposal, but it stil happen after I edit the description for the 15th times.
From the OP video in https://github.com/Expensify/App/issues/50270, I see that the composer input is briefly not visible.
So, I tried migrating ComposerWithSuggestions
to useOnyx to fix it and somehow https://github.com/Expensify/App/issues/50270 is also fixed. I tried reproducing this issue by editing >30 times the desc and can't repro the freeze anymore.
EDIT: Nevermind, after a few minutes, it becomes unresponsive.
Thanks for all the investigation so far @bernhardoj! Sounds like this one will be pretty hard to track down. Does your fix for https://github.com/Expensify/App/issues/50270 work more consistently? We might want to reopen that issue if so, since it might be that they are not directly related.
Does your fix for https://github.com/Expensify/App/issues/50270 work more consistently?
So far, yes.
@joekaufmanexpensify It sounds like it might be an idea to reopen #50270 since @bernhardoj can repro that one more consistently. I personally think we can probably close this issue since it's so hard to repro and doesn't seem to be something that would affect real users.
Hmm @hungvu193 had mentioned being able to reproduce both issues in the other issue. I'd be interested to hear if they were able to more consistently see this one, and if so, how they did that.
Yeah This issue is a little bit harder to reproduce that I need to repeat the steps couple of times.
๐ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐ธ
@NikkiWines @jjcoffee @adelekennedy this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
@hungvu193 Got it. But you still are able to consistently reproduce it without much effort?
@hungvu193 Got it. But you still are able to consistently reproduce it without much effort?
I am. Yes.
A little trick to reproduce this issue, you should edit the task with multiple lines few times.
Issue not reproducible during KI retests. (First week)
๐ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐ธ
@NikkiWines, @jjcoffee, @adelekennedy Huh... This is 4 days overdue. Who can take care of this?
Not me @jjcoffee - I think we may be ready to close this one though some compensation is definitely due here
I can't repro the exact same thing, but following the same steps I get some weird behaviour like the description showing as empty when I reopen the task to edit the description. I also get redirected to the report, rather than the task detail view.
https://github.com/user-attachments/assets/73f9dfa2-3445-493a-889f-abba70d5e218
@NikkiWines, @jjcoffee, @adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!
@hungvu193 or @bernhardoj Are you still able to repro this consistently?
Tried editing the desc 20 times but can't repro it (tried this too).
Same here. Cant repo ANR any more
๐ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐ธ
Asked for a retest with our QA team
@NikkiWines @jjcoffee @adelekennedy this issue is now 4 weeks old, please consider:
Thanks!
Issue not reproducible during KI retests. (Second week)
@adelekennedy Should we bump the price on this to get more eyes on it?
๐ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐ธ
@NikkiWines, @jjcoffee, @adelekennedy Eep! 4 days overdue now. Issues have feelings too...
If you havenโt already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.42-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5026821 Email or phone of affected tester (no customers): gatantm+920@gmail.com Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
Users can edit the task as many times as they want
Actual Result:
Seems that on all of the steps, changing title or description of the task or when going back the app becomes unresponsive and needs to be force closed
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/user-attachments/assets/9e9ed91c-bfdc-4d2c-8609-7a4ed8c534e3
logs (2).txt
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @jjcoffee