search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.56k stars 2.9k forks source link

[$250] Workspace Chat - First approver doesn't see whisper message in employee workspace chat #50017

Open IuliiaHerets opened 1 month ago

IuliiaHerets commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.42-1 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): applausetester+bm38@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Create a new workspace and enable workflow.
  3. Set the delay submission to "Manual."
  4. Add 3 members: an employee, Approver A (first approver), and Approver B (second approver).
  5. Set up the approval workflow as follows:
    • Employee submits to Approver A.
    • Approver B is the second approver.
  6. As the employee, submit an expense in the workspace chat.
  7. As Approver A, go to the employee's workspace chat and observe that the whisper message does not appear.
  8. Approve the expense as Approver A.
  9. As Approver B, go to the employee's workspace chat and observe that the whisper message is visible.

Expected Result:

The whisper message should consistently appear to both Approver A and Approver B.

Actual Result:

The whisper message does not appear for Approver A

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/2a74a3fd-c22a-47a1-ae7b-4d01878f9833

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021841694831847486781
  • Upwork Job ID: 1841694831847486781
  • Last Price Increase: 2024-11-07
Issue OwnerCurrent Issue Owner: @tgolen
melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

IuliiaHerets commented 1 month ago

We think that this bug might be related to #wave-collect - Release 1

IuliiaHerets commented 1 month ago

@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

kadiealexander commented 1 month ago

@IuliiaHerets it looks like you had approver 1 set as the approver but the account you were using to check the approver was approver A. Can you make sure that the user is the same and reopen if this is still happening?

IuliiaHerets commented 1 month ago

@kadiealexander Issue is still reproducible, the tester correct the steps a little.

  1. Go to https://staging.new.expensify.com/
  2. Create a new workspace and enable workflow.
  3. Set the delay submission to "Manual."
  4. Add 3 members: an employee, Approver A (first approver), and Approver B (second approver).
  5. Set up the approval workflow as follows:
    • Employee submits to Approver A.
    • Approver B is the second approver.
  6. As the employee, submit an expense in the workspace chat.
  7. As Approver A, go to the employee's workspace chat and observe that the whisper message does not appear.
  8. Approve the expense as Approver A.
  9. As Approver B, go to the employee's workspace chat and observe that the whisper message is visible.

https://github.com/user-attachments/assets/75cc46ef-0b8a-4bd8-a046-a243fa371f92

melvin-bot[bot] commented 1 month ago

Job added to Upwork: https://www.upwork.com/jobs/~021841694831847486781

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

melvin-bot[bot] commented 1 month ago

@shubham1206agra, @kadiealexander Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] commented 1 month ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 1 month ago

@shubham1206agra, @kadiealexander Still overdue 6 days?! Let's take care of this!

shubham1206agra commented 1 month ago

No proposals yet

melvin-bot[bot] commented 1 month ago

@shubham1206agra, @kadiealexander Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] commented 1 month ago

@shubham1206agra @kadiealexander this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] commented 1 month ago

@shubham1206agra, @kadiealexander Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] commented 1 month ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 1 month ago

@shubham1206agra, @kadiealexander 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

shubham1206agra commented 3 weeks ago

No proposals yet.

melvin-bot[bot] commented 3 weeks ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

kadiealexander commented 3 weeks ago

Not overdue or a high priority bug, reassigning for someone to keep an eye on as I'm OOO for the next two weeks.

melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 2 weeks ago

@MitchExpensify, @shubham1206agra, @kadiealexander Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

MitchExpensify commented 2 weeks ago

Waiting on proposals

muttmuure commented 2 weeks ago

Going to make this a hot pick as part of #quality

melvin-bot[bot] commented 2 weeks ago

@MitchExpensify @shubham1206agra @kadiealexander this issue is now 4 weeks old, please consider:

Thanks!

melvin-bot[bot] commented 2 weeks ago

@MitchExpensify, @shubham1206agra, @kadiealexander Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] commented 2 weeks ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

tgolen commented 2 weeks ago

I'm gonna grab this and try to take a look at it. Those whispers should be a backend thing, so I want to rule out any BE bugs if I can.

tgolen commented 2 weeks ago

Hm, @marcochavezf or @mountiny do you know more about this? Marco, it looks like maybe you added this whisper to Auth. I'm not exactly sure how it's supposed to work and it's a bit difficult to track down. I can put more time into finding it out, but I thought you might be able to spot the problem faster than I'm able to.

mountiny commented 2 weeks ago

I am not super familiar with this whisper either sorry

tgolen commented 1 week ago

bump @marcochavezf

marcochavezf commented 1 week ago

I will take a look at it today

marcochavezf commented 1 week ago

Today I prioritized a deploy blocker and a #stability issue, tomorrow I will prioritize this one

marcochavezf commented 1 week ago

Working on it here

melvin-bot[bot] commented 1 week ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

marcochavezf commented 1 week ago

PR ready for review