Open lanitochka17 opened 3 weeks ago
Triggered auto assignment to @OfstadC (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
@OfstadC FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
We think that this bug might be related to #wave-collect - Release 1
Edited by proposal-police: This proposal was edited at 2024-10-02 20:36:01 UTC.
Scan - "Delete" and "Replace" options are displayed for an admin which causes an error
readOnly
prop is not properly set to handle the case where admin/owner cannot edit the reciept.
https://github.com/Expensify/App/blob/19a137d26fee56f913eaec7c9b896915ddb002a9/src/components/ReportActionItem/MoneyRequestView.tsx#L528
readonly={readonly || !canEditReceipt}
. isAdmin || isManager ||
part from the condition below, if we want, we can keep isManager
.
https://github.com/Expensify/App/blob/19a137d26fee56f913eaec7c9b896915ddb002a9/src/libs/ReportUtils.ts#L3098-L3106The ‘Delete’ and ‘Replace’ options are displayed, but when ‘Delete’ is executed, an error occurs and when ‘Replace’ is executed, the receipt is replaced
In ReportUtils.canEditFieldOfMoneyRequest
:
If user is admin or manager, this function returns true
, so admins can edit receipt.
Remove isAdmin
and isManager
from this condition:
NA
Moving my proposal from here https://github.com/Expensify/App/issues/47242#issuecomment-2284327596
"Delete" and "Replace" options are displayed for an admin which causes an error
We are allowing Admin to edit receipt here https://github.com/Expensify/App/blob/7481b6ec6c5d0238d3c4aa9cf6e65325bec5741d/src/libs/ReportUtils.ts#L2934
We can remove isAdmin
from here
https://github.com/Expensify/App/blob/7481b6ec6c5d0238d3c4aa9cf6e65325bec5741d/src/libs/ReportUtils.ts#L2934
In case we only want to allow requestor to delete and replace the reciept than we can remove both options isAdmin
and isManager
Job added to Upwork: https://www.upwork.com/jobs/~021843656533685450338
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External
)
Is this still reproducible for everyone else? I'm only getting the download option as admin/owner:
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
@Ollyws, @OfstadC Eep! 4 days overdue now. Issues have feelings too...
@Ollyws @OfstadC this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
@Nodebrute @abzokhattab @daledah are you still able to reproduce?
@Ollyws I can no longer reproduce the bug.
https://github.com/user-attachments/assets/95809a7c-f68c-42f4-a570-9afc386e340c
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
I've asked for retesting in #qa
@Ollyws, @OfstadC Eep! 4 days overdue now. Issues have feelings too...
Waiting on QA to retest
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.43-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5035807 Email or phone of affected tester (no customers): sustinov@applausemail.com Issue reported by: Applause - Internal Team
Action Performed:
Prerequisite Create a workspace and invite an employee to the workspace Login as an owner and employee
Expected Result:
The workspace admin cannot edit the receipt file so there should not be "Delete" and "Replace" options
Actual Result:
The ‘Delete’ and ‘Replace’ options are displayed, but when ‘Delete’ is executed, an error occurs and when ‘Replace’ is executed, the receipt is replaced
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/user-attachments/assets/164a7d6d-600e-43b3-929c-a6811ec8c88a
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @OfstadC