Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.48k stars 2.83k forks source link

IOU - Web - Console error when selecting pay with Business bank account as recipient #50166

Open lanitochka17 opened 2 weeks ago

lanitochka17 commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.44.0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team

Issue found when executing PR https://github.com/Expensify/App/pull/50052

Action Performed:

  1. Go to https://staging.new.expensify.com/ and log in as user A
  2. Submit an expense in USD to user B who does not have an expensify account yet
  3. Navigate to the email box and click on the magic link inviting user B to pay the expense
  4. Select Pay with Expensify > Business bank account on the IOU preview

Expected Result:

There are no console errors

Actual Result:

There is a console error after selecting Pay with Expensify > Business bank account. It also happens if Pay elsewhere is selected

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/de505113-6a0d-4fff-bcdd-e95a670eb1e3

logs (2).txt

View all open jobs on GitHub

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

github-actions[bot] commented 2 weeks ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
lanitochka17 commented 2 weeks ago

We think that this bug might be related to #wave-collect - Release 2

cdOut commented 2 weeks ago

Hi, this was caused by my guided setup PR and is very similar to the previously solved bug here, I think just as before this is a backend problem.

cc @deetergp

allgandalf commented 2 weeks ago

We can remove the Blocker here as this is BE

jasperhuangg commented 2 weeks ago

@deetergp This seems to be a similar issue to https://github.com/Expensify/App/issues/48916, can you fix it in the back-end?

deetergp commented 1 week ago

@jasperhuangg It's similar but not the same. There is a mysterious onyx update setting nvp_onboarding to a blank string, but it's not coming from CompleteGuidedSetup which is where the one from https://github.com/Expensify/App/issues/48916 was coming. I tested yesterday and confirmed that that fix is still working as intended, but I cannot find where this change to a blank string is coming from. If you've got any thoughts or theories, I am all ears!

johncschuster commented 1 week ago

Bumping for Melv (discussion ongoing)

deetergp commented 1 week ago

Still have not unearthed where this is coming from. Will keep digging tomorrow.

johncschuster commented 6 days ago

Bumping for Melv 👍

deetergp commented 3 days ago

This one got shuffled to the side for a bit, but I'll dig back into it in the morning.

deetergp commented 1 day ago

Still haven't had a chance to get to this one.

melvin-bot[bot] commented 9 hours ago

@deetergp @johncschuster this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!