[$250] Onboarding - 'Submit an expense' task gets marked as complete when tracking an expense

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.44-3 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5039985 Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to https://staging.new.expensify.com/
2. Log in with new Gmail account
3. Select 'Get paid back by my employer' in onboarding modal
4. Enter user name and submit modal
5. Click on FAB > Track expense > Manual and finish the flow
6. Navigate to Concierge chat

Expected Result:

'Submit an expense' onboarding task should remain unchecked as the expense is not submitted yet

Actual Result:

'Submit an expense' gets marked as complete when tracking an expense

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [x] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/471c0408-3d7e-4dc7-bd3c-5d4f0a937d70

---

Note that the same issue can be observed when 'Chat and split expenses with friends' selected in onboarding modal In this scenario, the 'Start a chat' task gets marked as completed when tracking an expense:

https://github.com/user-attachments/assets/56bcad50-20d5-4841-9112-d76706c637e2

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021843765208299825426
• Upwork Job ID: 1843765208299825426
• Last Price Increase: 2024-10-08

[melvin-bot[bot]]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021843765208299825426

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[kubabutkiewicz]

Hello, Im Jakub from Callstack and would like to help with this issue

[kubabutkiewicz]

This seems to me that its working as expected or issue on the BE, when making a TrackExpense command in the response we are getting onyx data which indicate that Submit an expense should be marked as completed

[melvin-bot[bot]]

@greg-schroeder, @thesahindia Eep! 4 days overdue now. Issues have feelings too...

[greg-schroeder]

@kubabutkiewicz Okay so to be clear, Onyx Data shows this is actually expected in the end, and that "Submit an expense" is supposed to be checked there. Hmm. I wonder if it just needs to be re-named to "Create an expense" or if that is actually a bug?

[greg-schroeder]

I am asking the team

[kubabutkiewicz]

Okay so to be clear, Onyx Data shows this is actually expected in the end, and that "Submit an expense" is supposed to be checked there.

@greg-schroeder yes

[trjExpensify]

Moving this out of wave-collect to #convert as an onboarding task related issue if we need to do something here.

[melvin-bot[bot]]

@kubabutkiewicz @greg-schroeder @thesahindia this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[greg-schroeder]

checking with #convert team:

https://expensify.slack.com/archives/C07HPDRELLD/p1729192268616079

[melvin-bot[bot]]

@kubabutkiewicz, @greg-schroeder, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[greg-schroeder]

Bumped thread

[greg-schroeder]

Working to reproduce this now

[greg-schroeder]

I reproduced this on web staging again:

[greg-schroeder]

As originally noted in the OP: the same issue can be observed when 'Chat and split expenses with friends' selected in onboarding modal. In this scenario, the 'Start a chat' task gets marked as completed when tracking an expense.

Should we track that separately or handle it here? I'm assuming it's the same RC and they're both onboarding tasks, but are obviously separate flows.

[melvin-bot[bot]]

@kubabutkiewicz, @greg-schroeder, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[greg-schroeder]

Awaiting proposals ... or lemme check if this in fact BE?

[melvin-bot[bot]]

@kubabutkiewicz @greg-schroeder @thesahindia this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[greg-schroeder]

Same as above

[kubabutkiewicz]

@greg-schroeder did someone from BE team checked this? because I don't think we can do something on frontend to fix that

[greg-schroeder]

Awaiting an internal volunteer