Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.47k stars 2.82k forks source link

[$250] App crashes when opening report with unapproved expenses #50191

Open m-natarajan opened 1 week ago

m-natarajan commented 1 week ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: Reproducible in staging?: need reproduction Reproducible in production?: need reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @carlosmiceli Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1727970012031259

Action Performed:

1- Open report and create/submit an expense. 2- Before having that expense approved, create another expense. 3- Open the report and open the second expense to try to submit it.

Expected Result:

Open expense without any issues.

Actual Result:

App freezes and later crashes, with expenses only showing halfway.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/user-attachments/assets/ae5c0b30-0474-4b56-bad1-2987e2ed554b

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021843283405105641085
  • Upwork Job ID: 1843283405105641085
  • Last Price Increase: 2024-10-14
Issue OwnerCurrent Issue Owner: @ntdiary
melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

MelvinBot commented 1 week ago

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

melvin-bot[bot] commented 1 week ago

Job added to Upwork: https://www.upwork.com/jobs/~021843283405105641085

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

shahinyan11 commented 1 week ago

@m-natarajan @isabelastisser I think the Action Performed: steps are not detailed and enough clear for external contributors. Could you please provide more detailed steps and video. I think you should add how to get to unapproved expenses.

carlosmiceli commented 1 week ago

@shahinyan11 what other details would we need to see? I reported the experience just as I had it, or are you saying that it's not reproducible?

shahinyan11 commented 1 week ago

@shahinyan11 what other details would we need to see? I reported the experience just as I had it, or are you saying that it's not reproducible?

How to have unapproved expense ? If contributor is not familiar with Expensify how to know what steps should be done to get approved expense

carlosmiceli commented 1 week ago

Oh, I see, just updated the steps. In this case, there's no need to have expenses approved.

shahinyan11 commented 1 week ago

@carlosmiceli Should this be a 1/1 chat or a workspace. If a workspace, is there any configuration needed for that workspace ?

carlosmiceli commented 1 week ago

It's a workspace, but let's get @heyjennahay 's advice here: I found this issue while trying to submit Expensify coffee expenses, Jenna. What other info should I put in here for proper testing?

melvin-bot[bot] commented 3 days ago

@carlosmiceli, @ntdiary, @isabelastisser Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

isabelastisser commented 3 days ago

bump @heyjennahay for an update.

heyjennahay commented 21 hours ago

This is an expense on a workspace. Looking at the video it is just a Processing expense which has not received the first approval, is that correct @carlosmiceli ?

I'm curious if you have logs from the app which show the crash which might be helpful here?

melvin-bot[bot] commented 16 hours ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

carlosmiceli commented 15 hours ago

That's correct @heyjennahay! As of right now, I have about 4 unapproved expenses in that report, and it's still happening that it crashes when i want to open any of those expenses in ND.

@dbond09 I found this SO, should I still follow this to see the logs of ND when crashing? Just checking first since it's 5 years old.