[$250] Task - Task name not updated in chat when it got changed offline

IuliiaHerets commented 3 days ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.44.8 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5042712 Issue reported by: Applause Internal Team

Action Performed:

Go to https://staging.new.expensify.com/
Open any chat
Click on "+" > Assign task
Add the the task name and create a task
Disable internet connection
Change the task name to something else
Return to the chat if needed

Expected Result:

The updated task name is displayed in the chat

Actual Result:

The old task name is still displayed in the chat

Workaround:

Unknown

Platforms:

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/0621573e-d109-4dd1-86d4-4cf23eaa7fa2

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021842218862975991434
Upwork Job ID: 1842218862975991434
Last Price Increase: 2024-10-04

Issue Owner

Current Issue Owner: @ishpaul777

melvin-bot[bot] commented 3 days ago

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 3 days ago

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

github-actions[bot] commented 3 days ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

mkzie2 commented 3 days ago

Edited by proposal-police: This proposal was edited at 2024-10-04 09:12:30 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The old task name is still displayed in the chat when updating task name offline

What is the root cause of that problem?

There have been an unsynchronization issue between Onyx data subscribed in component via useOnyx and the data in utils file:

https://github.com/Expensify/App/blob/92eee5f433c15203e37cf5c87ea57fd9a1664b3e/src/components/ReportActionItem/TaskPreview.tsx#L76

https://github.com/Expensify/App/blob/9b7af888d3e6ff12ee1e043a69932de9aad3ddd7/src/libs/TaskUtils.ts#L41

Causing the utils file data to be stale (not updated).

What changes do you think we should make in order to solve the problem?

There have been many issues like https://github.com/Expensify/App/issues/49551 to remove usages of using Onyx.connect in utils files, we should pass Onyx data directly from component instead and let these utils file only handle its utility.

So in this case, update getTaskTitle to receive taskReport directly instead of taskReportID and pass it from TaskPreview.

There are 2 usages of getTaskTitle, we need to update them accordingly.

What alternative solutions did you explore (Optional)?

We can update the task's parent report action's childReportName optimistically when editing task title:

https://github.com/Expensify/App/blob/52aa9a953167814edab2b49fda9ed5df51200d40/src/libs/actions/Task.ts#L497

because it's used as a fallback task title:

https://github.com/Expensify/App/blob/92eee5f433c15203e37cf5c87ea57fd9a1664b3e/src/components/ReportActionItem/TaskPreview.tsx#L76

mkzie2 commented 3 days ago

Update proposal

Add alternative solution

melvin-bot[bot] commented 3 days ago

Job added to Upwork: https://www.upwork.com/jobs/~021842218862975991434

melvin-bot[bot] commented 3 days ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

flodnv commented 3 days ago

@mkzie2 any idea which PR caused this regression?

@ishpaul777 what are your thoughts on the proposal?

ishpaul777 commented 3 days ago

looking 👀

ishpaul777 commented 2 days ago

@mkzie2's Proposal makes sense and seems to be working, but we should know the offending PR before moving forward with a fix and assigning a contributor

mkzie2 commented 2 days ago

I tried reverting PR https://github.com/Expensify/App/pull/49686, specifically this change and it fixed the issue though I haven't understood why.

ishpaul777 commented 2 days ago

reverting here to confirm if its the offending PR

ishpaul777 commented 2 days ago

Confirmed that reverting it fixes the issue

https://github.com/user-attachments/assets/ffd4b01d-7389-42f4-a9b6-f40ee597aba8

ishpaul777 commented 2 days ago

Since we can't understand why the PR causes the issue, instead of rushing a fix i think we should revert to unblock the deploy and let orignal author take care of this in a second try. Any thoughts @flodnv @jasperhuangg ??

The given solution works in my testing and i dont think there will be any side effects, its just that proposal does not provide enough Root cause Analysis