[HOLD for payment 2024-10-22] [$67.50] Chat - There is no closing question mark on delete comment confirmation modal in Spanish

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.45-2 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5045504 Email or phone of affected tester (no customers): applausetester+vd_web100424@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

Pre-requisite: the user must have set the language preference to Spanish.

1. Go to any chat.
2. Right click on any message (send a message is there is none).
3. Click on "Eliminar comentario".

Expected Result:

Text on confirmation modal should say: ¿Estás seguro de que quieres eliminar este comentario?

Actual Result:

Text on confirmation modal says: ¿Estás seguro de que quieres eliminar este comentario

Workaround:

Unknown

Platforms:

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [x] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021843383751880246894
• Upwork Job ID: 1843383751880246894
• Last Price Increase: 2024-10-07

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot[bot]]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@strepanier03 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[MuaazArshad]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - There is no closing question mark on delete comment confirmation modal in Spanish

What is the root cause of that problem?

We are not adding ? here https://github.com/Expensify/App/blob/99f280b0edae75ff59614a1c5e98c47b39800aa5/src/languages/es.ts#L636

What changes do you think we should make in order to solve the problem?

We should add it like this

deleteConfirmation: ({action}: DeleteConfirmationParams) =>
            `¿Estás seguro de que quieres eliminar este ${action?.actionName === CONST.REPORT.ACTIONS.TYPE.IOU ? 'gasto?' : 'comentario?'}`,

What alternative solutions did you explore? (Optional)

[abzokhattab]

Edited by proposal-police: This proposal was edited at 2024-10-05 15:54:14 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is no closing question mark on delete comment confirmation modal in Spanish

What is the root cause of that problem?

this translation is not correct https://github.com/Expensify/App/blob/87ea10031ba24d3fa3a5d3c71cc4de030085d4cf/src/languages/es.ts#L636-L637

What changes do you think we should make in order to solve the problem?

add question mark to the end

deleteConfirmation: ({action}: DeleteConfirmationParams) =>
            `¿Estás seguro de que quieres eliminar este ${action?.actionName === CONST.REPORT.ACTIONS.TYPE.IOU ? 'gasto' : 'comentario'}?`,

What alternative solutions did you explore? (Optional)

[abzokhattab]

Proposal updated

Added the exact code changes

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021843383751880246894

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

[strepanier03]

Updated the job post and the title as this change is very simple and small, and we agreed to lower the price on this one.

[parotax]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We are missing a "?" at the end of delete comment confirmation modal's spanish text.

What is the root cause of that problem?

In the src/languages/es.ts file we ask for delete confirmation without the "?":

deleteConfirmation: ({action}: DeleteConfirmationParams) =>
            `¿Estás seguro de que quieres eliminar este ${action?.actionName === CONST.REPORT.ACTIONS.TYPE.IOU ? 'gasto' : 'comentario'}`,

What changes do you think we should make in order to solve the problem?

Add the missing "?" in the end of the string in the translation file.

[melvin-bot[bot]]

📣 @parotax! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Format:

   Contributor details
   Your Expensify account email: <REPLACE EMAIL HERE>
   Upwork Profile Link: <REPLACE LINK HERE>

[strepanier03]

This might be a dupe of https://github.com/Expensify/App/issues/49893, going to check and if so close this out.

[parotax]

Contributor details Your Expensify account email: luukas.k.lehtinen@gmail.com Upwork Profile Link: https://www.upwork.com/freelancers/~01f29577390fed6ca6

[melvin-bot[bot]]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[parotax]

This might be a dupe of #49893, going to check and if so close this out.

@strepanier03 To me it doesn't seem to be a duplicate. It is just a similar issue in the "Download attachment" modal. This is in "Delete message" modal.

[eh2077]

Thank you for your speedy proposals!

This one is really straightforward. I think we should go with @MuaazArshad 's proposal as they're the first to point the root cause.

@MuaazArshad posted at 2024-10-05T15:51:45Z while @abzokhattab posted at 2024-10-05T15:54:03Z

🎀👀🎀 C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @neil-marcellini, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[neil-marcellini]

Thank you for your speedy proposals!

This one is really straightforward. I think we should go with @MuaazArshad 's proposal as they're the first to point the root cause.

I agree, sounds good. @strepanier03 this one is so simple that I would suggest we pay $0 for it, or at least next time we have a similar copy change. No C+ is really needed either.

[melvin-bot[bot]]

📣 @MuaazArshad You have been assigned to this job! Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs! Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot[bot]]

@strepanier03, @neil-marcellini, @MuaazArshad, @eh2077 Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.48-2 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/50579

If no regressions arise, payment will be issued on 2024-10-22. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @MuaazArshad requires payment (Needs manual offer from BZ)
• @eh2077 requires payment through NewDot Manual Requests

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@eh2077] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@eh2077] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@eh2077] Determine if we should create a regression test for this bug.
• [ ] [@eh2077] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[strepanier03]

HOLD FOR 2024-10-22

Payment Summary

• [ ] @MuaazArshad - $67.50 via Upwork (offer)
• [ ] @eh2077 - $67.50 via NewDot Manual Requests