[$250] Expense - Unapprove system message changes format after unapproving a scanning expense

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.45-2 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): applausetester+pso@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Add approvals feature is enabled in Workflows.

1. Go to staging.new.expensify.com
2. Go to workspace chat (must have no unsettled expense).
3. Submit a scan expense.
4. While the receipt is scanning, go to expense report.
5. Click Approve.
6. Click on the report header.
7. Click Unapprove while the receipt is still scanning.
8. Note that the unapprove system message is "unapproved x".
9. Refresh the page.

Expected Result:

The unapprove system message should remain "unapproved x".

Actual Result:

The unapprove system message changes to You unapproved this report

This issue only happens when the expense is a scan expense and the receipt is scanning.

Workaround:

Unknown

Platforms:

• [x] Android: Native
• [x] Android: mWeb Chrome
• [x] iOS: Native
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/7aad5489-a754-43c2-a8e6-c2254e24d09f

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021843641880485944632
• Upwork Job ID: 1843641880485944632
• Last Price Increase: 2024-10-08

Issue Owner

Current Issue Owner: @rojiphil

[melvin-bot[bot]]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[IuliiaHerets]

@bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[truph01]

Edited by proposal-police: This proposal was edited at 2024-10-07 02:18:22 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The unapprove system message changes to You unapproved this report

What is the root cause of that problem?

• We don't have logic to handle UNAPPROVED system messages on FE side.

  What changes do you think we should make in order to solve the problem?

  1. Add a UNAPPROVED else if in this:

 } else if (ReportActionsUtils.isActionOfType(action, CONST.REPORT.ACTIONS.TYPE.UNAPPROVED)) {
            const amount = ReportActionsUtils.getOriginalMessage(action)?.amount;
            const currency = ReportActionsUtils.getOriginalMessage(action)?.currency;
            children = <ReportActionItemBasicMessage message={`Unapproved ${CurrencyUtils.convertToDisplayString(amount, currency)}`} />;

The text can be updated later.

2. The same logic should be applied when displaying message in LHN, copy message, report title, ...

   What alternative solutions did you explore? (Optional)

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021843641880485944632

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

[melvin-bot[bot]]

@rojiphil, @bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[rojiphil]

This issue is fixed in this PR. Let's close this @bfitzexpensify

https://github.com/user-attachments/assets/12825e4e-dd68-4b59-9c67-815e1b241794