[Debug Mode] Add transaction and violation data to debug mode

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

3.5k stars 2.85k forks source link

[Debug Mode] Add transaction and violation data to debug mode #50335

Open puneetlath opened 2 weeks ago

puneetlath commented 2 weeks ago

As discussed here, let's add transaction and transaction violation data to debug mode.

cc @pac-guerreiro

Issue Owner

Current Issue Owner: @pac-guerreiro

melvin-bot[bot] commented 2 weeks ago

Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new.

melvin-bot[bot] commented 2 weeks ago

:warning: It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time :warning:

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

puneetlath commented 2 weeks ago

@dubielzyk-expensify we shouldn't need you here since this is just for debug mode, but I'll bring you back in if we do.

pac-guerreiro commented 2 weeks ago

Hi! I’m Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this task!

pac-guerreiro commented 1 week ago

I didn't have much time as I wanted to work on this yesterday but here goes my update!

Yesterday's update:

[x] Create DebugUtils.validateTransactionDraftProperty

Todo:

[ ] Add remaining property validations to DebugUtils.validateTransactionDraftProperty
[ ] Add unit tests for DebugUtils.validateTransactionDraftProperty
[ ] Do some manual tests by modifying transaction data and saving it
[ ] Finish transaction violations tab
[ ] Create button in debug report page to redirect to debug transaction page
[ ] Add screen recordings
[ ] Add QA testing steps

pac-guerreiro commented 1 week ago

Today's update:

[x] Add remaining property validations to DebugUtils.validateTransactionDraftProperty
[x] Add unit tests for DebugUtils.validateTransactionDraftProperty
[x] Do some manual tests by modifying transaction data and saving it

Todo:

[ ] Create TRANSACTION_FORM_INPUT_IDS
[ ] Finish transaction violations tab
[ ] Create button in debug report page to redirect to debug transaction page
[ ] Add screen recordings
[ ] Add QA testing steps

pac-guerreiro commented 1 week ago

Today's update:

[x] Create TRANSACTION_FORM_INPUT_IDS
[x] Create button in debug report page to redirect to debug transaction page
[x] Create button in debug report action page to redirect to debug transaction page
[x] Create button in debug transaction to redirect to report

Todo:

[ ] Finish transaction violations tab
[ ] Add screen recordings
[ ] Add QA testing steps

pac-guerreiro commented 1 week ago

Today's update:

[x] Add transaction violation creation page

Todo:

[ ] Fix issue where newly created transaction violation replaces all existing transaction violations
[ ] Add transaction violation page to allow users to modify data, view JSON data representation and delete data
[ ] Finish transaction violations tab
[ ] Add screen recordings
[ ] Add QA testing steps

pac-guerreiro commented 4 days ago

Today's update:

[x] Fix issue where newly created transaction violation replaces all existing transaction violations
[x] Add transaction violation page to allow users to modify data, view JSON data representation and delete data
[x] Finish transaction violations tab

Todo:

[ ] Fix stale transaction violation data after updating a violation until the app is refreshed
[ ] Refactor debug details constant field options. There are field name collisions between data types
[ ] Add screen recordings
[ ] Add QA testing steps

pac-guerreiro commented 3 days ago

Today's update:

[x] Fix stale transaction violation data after updating a violation until the app is refreshed
[x] Refactor debug details constant field options. There are field name collisions between data types

Todo:

[ ] Add missing field names in debug details constant field options
[ ] Add screen recordings
[ ] Add QA testing steps

pac-guerreiro commented 2 days ago

@DylanDylann @puneetlath

The PR is now ready for review 😄

pac-guerreiro commented 1 day ago

@puneetlath

All feedback from @fabioh8010 was addressed today, just waiting on @DylanDylann to do his review 😄

pac-guerreiro commented 14 hours ago

@puneetlath

I fixed the jest unit tests that were failing in the PR

Still waiting on additional review from @DylanDylann 😄