search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.48k stars 2.83k forks source link

Write unit tests for updated `ReportActionItem` text depending on given `originalMessage` data #50351

Open Beamanator opened 1 week ago

Beamanator commented 1 week ago

Background:

strongly encouraged suggestion: Write some automated tests to cover this change. It's a very good candidate for unit tests, and they'd go a long way to make this code more robust and avoid it breaking in the future.

That ^ suggestion was given here and I agree we should write unit tests for the changes in that PR 👍 I'm going to make this external b/c it would be great to get external help on this 🙏

Expected Result:

Please add unit tests for:

  1. UI tests rendering <ReportActionItem> using @testing-library/react-native.
  2. Additional getReportName tests covering changes from https://github.com/Expensify/App/pull/49909
melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Beamanator commented 1 week ago

Assigning @allgandalf from https://expensify.slack.com/archives/C02NK2DQWUX/p1728329535786379 🙏

allgandalf commented 1 week ago

@Beamanator should i wait for https://github.com/Expensify/App/pull/49909 to get merged ?

Beamanator commented 1 week ago

Oh good call 😅 You caaaan start writing tests if you want, but obviously they shouldn't pass till #49909 is merged 😬

Beamanator commented 1 week ago

Boom, PR merged!

allgandalf commented 1 week ago

PR will be ready over the weekend 👍

Christinadobrzyn commented 4 days ago

Ooh - looks like PR is in production - https://github.com/Expensify/App/pull/49909

Adding a payment date to this GH.

Christinadobrzyn commented 1 day ago

Payment wasn't triggered - I think this is the right summary

Payouts due:

Do we need a regression test?

Beamanator commented 1 day ago

Hmm I don't actually think the PR was created yet, 😅 @allgandalf have you started this yet?

allgandalf commented 1 day ago

Hmm I don't actually think the PR was created yet, 😅 @allgandalf have you started this yet?

This was weekly and didn't show up on K2 for some reason, I will raise one today/tomorrow 👍

Beamanator commented 1 day ago

aah funky! glad it's daily now :D and no worries for the delay, was just curious haha