[$250] Search - Hold and Delete option are available for expense in the deleted (archived) workspace

lanitochka17 commented 3 days ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.39-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com Issue reported by: Applause - Internal Team

Action Performed:

Go to staging.new.expensify.com
Go to workspace chat
Submit an expense
Delete the workspace
Go to Search
Select the expense in Step 3 via checkbox
Click on the dropdown

Expected Result:

Hold and Delete option should not be available for expense in the deleted (archived) workspace

Actual Result:

Hold and Delete option are available for expense in the deleted (archived) workspace

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/25e9dd75-9a7c-4c9d-a509-c84e6bbc6357

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021843452809268772596
Upwork Job ID: 1843452809268772596
Last Price Increase: 2024-10-08

Issue Owner

Current Issue Owner: @fedirjh

melvin-bot[bot] commented 3 days ago

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 commented 3 days ago

@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 commented 3 days ago

We think that this bug might be related to #wave-control

Nodebrute commented 3 days ago

Edited by proposal-police: This proposal was edited at 2024-10-07 19:47:40 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hold and Delete option are available for expense in the deleted (archived) workspace

What is the root cause of that problem?

Here we set canHold to item.canHold but when we delete workspace item.canHold will still be true https://github.com/Expensify/App/blob/fb4e24eca0905c8dec0c6dc69b4758aa66f2a791/src/components/Search/index.tsx#L84

What changes do you think we should make in order to solve the problem?

We need to add new checks here for cases like where if workspace is deleted we don't show hold button. We can do something like this here

   const isArchivedReport = ReportUtils.isArchivedRoomWithID(item.reportID)
    const canHoldtransaction = !isArchivedReport && item.canHold

and then we can use this here canHold: canHoldtransaction

If we also want to hide delete button we can do the same for canDelete. We should also look for other cases where we don't want to hold and delete button and fix that here too.

What alternative solutions did you explore? (Optional)

Alternatively, we can add !isArchivedReport here https://github.com/Expensify/App/blob/fb4e24eca0905c8dec0c6dc69b4758aa66f2a791/src/components/Search/SearchPageHeader.tsx#L182

And if we want to hide the delete button we can do the same for delete button

ChavdaSachin commented 3 days ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hold and Delete option are available for expense in the deleted (archived) workspace

What is the root cause of that problem?

When we delete workspace here we only set archive rules for workspace reports, and workspace transactions retains the last state it had when workspace was archived. Hence when we fetch transactions from ONYX - the transaction properties are outdated.

What changes do you think we should make in order to solve the problem?

To solve this issue we should set transaction properties canHold and canDelete to false for every transaction in workspace to be deleted.
So similar to how we archive reports when we delete workspace, we need to set canHold and canDelete properties for all workspace transactions to false and pass it to API data here. https://github.com/Expensify/App/blob/1fb0d01a98454954cd66e5d0eccd91833397b3f5/src/libs/actions/Policy/Policy.ts#L283-L362

We might need BE support here as well. This will avoid current and future problems it could cause.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

melvin-bot[bot] commented 3 days ago

Job added to Upwork: https://www.upwork.com/jobs/~021843452809268772596

melvin-bot[bot] commented 3 days ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

mallenexpensify commented 3 days ago

@fedirjh are you able to reproduce? I wasn't (but I did a couple additional steps to add another workspace cuz I couldn't delete mine without another)

fedirjh commented 1 day ago

@mallenexpensify I was able to reproduce. The bug appears on the search page, not the expense page :

mallenexpensify commented 1 day ago

Thanks @fedirjh , added Help Wanted, can you review the proposals above? Thx

Expensify / App