search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.51k stars 2.86k forks source link

[HOLD for payment 2024-10-17] [HOLD for payment 2024-10-16] Accounting - Empty row is displayed in accountings page #50379

Closed IuliiaHerets closed 3 weeks ago

IuliiaHerets commented 3 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.46-1 Reproducible in staging?: Y Reproducible in production?: N Email or phone of affected tester (no customers): applausetester+shsb22cp111@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

  1. Log in to any account
  2. Create a new workspace
  3. Navigate to more features > Enable Accounting
  4. Navigate to accounting page and observe the fifth row

Expected Result:

No empty row is displayed in the page

Actual Result:

An empty row is displayed with a connect button which doesn't navigate to anything when clicked

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/dd2c03d4-3042-4e7f-ad9c-821c10881d0e

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @joekaufmanexpensify
melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

github-actions[bot] commented 3 weeks ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

IuliiaHerets commented 3 weeks ago

We think that this bug might be related to #wave-control

mkzie2 commented 3 weeks ago

Edited by proposal-police: This proposal was edited at 2024-10-08 09:25:12 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

An empty row is displayed with a connect button which doesn't navigate to anything when clicked

What is the root cause of that problem?

QBD is included in the connections list here:

https://github.com/Expensify/App/blob/256a747852de4882a989ae012647ed9cfe0a0f62/src/CONST.ts#L2304

But its integration data has not been defined yet:

https://github.com/Expensify/App/blob/56ca85f6e54c53ecb825807fe935df0c6dbe6105/src/pages/workspace/accounting/utils.tsx#L40

Causing the menu items here to have one empty row:

https://github.com/Expensify/App/blob/0c52433938b9e4a2037489b8893c03684ed888ea/src/pages/workspace/accounting/PolicyAccountingPage.tsx#L387

What changes do you think we should make in order to solve the problem?

Early return for undefined integrationData and filter the otherIntegrations to only get truthy values.

We faced this problem several times in the past when a new integration is added. I think we should not ignore it because we will get more and more integrations in the future.

ZhenjaHorbach commented 3 weeks ago

@hoangzinh @lakchote This is ours I think we can fix it in one of our PRs

hoangzinh commented 3 weeks ago

I think we can spin up a quick PR to remove the deploy blocker.

hoangzinh commented 3 weeks ago

@ZhenjaHorbach are you available to open a PR? I can help to review

ZhenjaHorbach commented 3 weeks ago

@ZhenjaHorbach are you available to open a PR? I can help to review

Yes I will create after 5 minutes

MonilBhavsar commented 3 weeks ago

This is fixed. Thanks all for the help!

Screenshot 2024-10-08 at 5 17 55 PM
melvin-bot[bot] commented 3 weeks ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 3 weeks ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.46-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-16. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 3 weeks ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

melvin-bot[bot] commented 3 weeks ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.47-4 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-17. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 3 weeks ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: