Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.46k stars 2.81k forks source link

[$250] Android - Crash when kill the app and reopen it #50463

Open lanitochka17 opened 2 days ago

lanitochka17 commented 2 days ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.46-1 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): gocemate+a2536@gmail.com Issue reported by: Applause - Internal Team

Action Performed:

  1. Install the New dot app
  2. Open android app
  3. Login with new gmail account
  4. Complete the onboarding modal
  5. Kill the app
  6. Open the app

Expected Result:

App should open

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/f45004e6-35c5-4e47-bbed-6f5bd166123b

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021843775413325774813
  • Upwork Job ID: 1843775413325774813
  • Last Price Increase: 2024-10-08
Issue OwnerCurrent Issue Owner: @DylanDylann
melvin-bot[bot] commented 2 days ago

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

github-actions[bot] commented 2 days ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
srikarparsi commented 2 days ago

Not able to reproduce on my physical ios device with a new account. Going to try on android emulator.

thienlnam commented 2 days ago

There's been an emerging crash in firebase that looks like it might be related here com.expensify.chat_issue_4f8a216f0a769e684d009b28ef9bd7d4_crash_session_6705473302F5000179E748FD60E92734_DNE_0_v2_stacktrace.txt

SurfaceMountingManager.getViewState

Appears to be present in a few different versions, so maybe not a deploy blocker

thienlnam commented 2 days ago

Potentially related: https://github.com/facebook/react-native/issues/38743

thienlnam commented 2 days ago

@kirillzyusko Do you think this https://github.com/Expensify/App/pull/37891 would address this crash as well?

srikarparsi commented 2 days ago

I'm not able to reproduce on an emulator in production https://github.com/user-attachments/assets/7a55635c-6cfa-4014-8dc1-3d6b43938a9d

srikarparsi commented 2 days ago

I am able to reproduce on staging. But reopening the app does work so it doesn't continually crash. Future quit/reopens don't crash the app either. https://github.com/user-attachments/assets/ca340a7e-ccd4-417d-93d6-916f02cd59a8

thienlnam commented 2 days ago

Hmm, this crash has been happening quite a bit - perhaps we can get some eyes on this?

melvin-bot[bot] commented 2 days ago

Current assignee @srikarparsi is eligible for the DeployBlockerCash assigner, not assigning anyone new.

melvin-bot[bot] commented 2 days ago

Job added to Upwork: https://www.upwork.com/jobs/~021843775413325774813

melvin-bot[bot] commented 2 days ago

⚠️ This issue has had its price increased by 4x or more. Please review the issue and ensure the price is correct.

github-actions[bot] commented 2 days ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
melvin-bot[bot] commented 2 days ago

Upwork job price has been updated to $250

melvin-bot[bot] commented 2 days ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

kirillzyusko commented 1 day ago

Do you think this https://github.com/Expensify/App/pull/37891 would address this crash as well?

I tested and in my case it still crashes 😔

mountiny commented 1 day ago

@thienlnam from the firebase, it seems like this was happening in previous builds, too. Should we demote?

thienlnam commented 1 day ago

Discussion here: https://expensify.slack.com/archives/C01GTK53T8Q/p1728413409127509