Open lanitochka17 opened 2 weeks ago
Triggered auto assignment to @sonialiap (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
@sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Going back from not found tax page leads to workspace list page.
When we disable the tax page, it's expected that a full screen not found page will show. The reason pressing back leads to the workspace list page is because a Navigation.dismissModal
is called, which closes the workspace details page.
shouldShowFullScreenFallback
is true if the feature is disabled or the policy is not accessible.
https://github.com/Expensify/App/blob/5d25b40eab1416d2d67624a376099853a2b6af86/src/pages/workspace/AccessOrNotFoundWrapper.tsx#L169
I think we should only close the workspace detail page if the policy is not accessible. To do that, we need to pass both isFeatureEnabled
and isPolicyNotAccessible
to PageNotFoundFallback
and remove the shouldShowFullScreenFallback
props and instead, add it as a local variable in PageNotFoundFallback
.
isFeatureEnabled={isFeatureEnabled}
isPolicyNotAccessible={isPolicyNotAccessible}
Then, in PageNotFoundCallback, https://github.com/Expensify/App/blob/5d25b40eab1416d2d67624a376099853a2b6af86/src/pages/workspace/AccessOrNotFoundWrapper.tsx#L88-L98
only use dismissModal
if the policy is not accessible. If the feature is disabled, then we will just go back.
const shouldShowFullScreenFallback = !isFeatureEnabled || isPolicyNotAccessible;
onBackButtonPress={() => {
if (isPolicyNotAccessible) {
Navigation.dismissModal();
return;
}
Navigation.goBack(policyID && !isMoneyRequest ? ROUTES.WORKSPACE_PROFILE.getRoute(policyID) : undefined);
}}
Job added to Upwork: https://www.upwork.com/jobs/~021845793851841023680
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External
)
Got assigned today. Will review the proposal.
I think @bernhardoj's proposal looks good. We'll need to check if it exists for other pages such as "Tags", etc.
🎀 👀 🎀 C+ reviewed.
Triggered auto assignment to @madmax330, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
PR is ready cc: @mananjadhav
Thanks, I'll review and test by tomorrow.
Reviewing
label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.53-1 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-11-01. :confetti_ball:
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.46-3 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5053996 Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
In ND the user is navigated to the LHP/WS editor page
Actual Result:
The user is shown "Ops...It's not here" page, the "Back" button takes you back to the WS selection page(User leaves the WS editor page)
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/user-attachments/assets/f79895d5-f082-4c99-9529-3921efb87aa1
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @sonialiap