[$250] Report fields - Feature can be enabled in collect workspace

IuliiaHerets commented 1 week ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.46-1 Reproducible in staging?: Y Reproducible in production?: Y Issue reported by: Applause Internal Team

Action Performed:

Precondition: user has Collect workspace.

Go ws settings > More features
Enable Accounting
Go to Accounting > Connect QBO integration
Disconnect QBO integration

Expected Result:

Report fields, as feature, available in Control workspace, disappeared from LHN.

Actual Result:

Report fields stays in LHN. User can access tab and add report filed to a collect workspace.

Workaround:

Unknown

Platforms:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/cbbe90ce-9229-4bc8-bd13-f8097e24a664

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021844128989949063152
Upwork Job ID: 1844128989949063152
Last Price Increase: 2024-10-16

Issue Owner

Current Issue Owner: @allgandalf

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

IuliiaHerets commented 1 week ago

We think that this bug might be related to #wave-control

IuliiaHerets commented 1 week ago

@slafortune FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

mkzie2 commented 1 week ago

Edited by proposal-police: This proposal was edited at 2024-10-09 21:40:29 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Report fields stays in LHN. User can access tab and add report filed to a collect workspace.

What is the root cause of that problem?

When removing any connection, we didn't turn off report field feature if it is not control policy:

https://github.com/Expensify/App/blob/3a6676eb0b8d241cbc94e3b64424c8c9a9ae7e0a/src/libs/actions/connections/index.ts#L22

What changes do you think we should make in order to solve the problem?

Add an additional logic to line:

const isCollectWorkspace = policy.type === 'team';
if (isCollectWorkspace && ['quickbooksOnline', 'xero', 'quickbooksDesktop'].includes(connectionName)) {
    optimisticData.push({
        onyxMethod: Onyx.METHOD.MERGE,
        key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
        value: {
            areReportFieldsEnabled: false,
            pendingFields: {
                areReportFieldsEnabled: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
            },
        },
    });

    successData.push({
        onyxMethod: Onyx.METHOD.MERGE,
        key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
        value: {
            pendingFields: {
                areReportFieldsEnabled: null,
            },
        },
    });

    failureData.push({
        onyxMethod: Onyx.METHOD.MERGE,
        key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
        value: {
            areReportFieldsEnabled: policy?.areReportFieldsEnabled,
            pendingFields: {
                areReportFieldsEnabled: null,
            },
        },
    });
}

BE should fix it as well. In detail, when we disconnect, BE needs to turn off report field feature as well.

melvin-bot[bot] commented 1 week ago

Job added to Upwork: https://www.upwork.com/jobs/~021844128989949063152

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

allgandalf commented 1 week ago

@slafortune , a thought:

We should never allow the toggle of report fields unless the workspace itself in on a control plan, it's a control plan only feature, can you take it to our slack #expense channel and tag me there? the expected result doesn't seem right, please tag me there too

melvin-bot[bot] commented 1 day ago

@slafortune, @allgandalf Eep! 4 days overdue now. Issues have feelings too...

allgandalf commented 1 day ago

bump on ^ @slafortune

trjExpensify commented 1 day ago

Report fields are a control feature, moving this to #expense.

slafortune commented 1 day ago

Perfect since everything Collect or Control is going to the Expenses Project

Sorry for my delay @allgandalf

We should never allow the toggle of report fields unless the workspace itself in on a control plan, it's a control plan only feature, can you take it to our slack #expense channel and tag me there? the expected result doesn't seem right, please tag me there too

Report fields unrelated to any accounting integrations are not supported on the Collect workspace This bug had been related to the Collect workspace project since the QBO connection is allowed on the Collect workspace - which allows for report fields.

if connected to an accounting integration that is allowed on the collect workspace - report fields are enabled. When disconnecting - report fields should be removed.

slafortune commented 1 day ago

Sorry - some keyboard shortcut closed that 😱

mkzie2 commented 22 hours ago

Proposal updated

melvin-bot[bot] commented 22 hours ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Expensify / App