Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.5k stars 2.85k forks source link

[$250] Hybrid App - The Duplicate flag on an expense cannot be dismissed, even if there are no duplicates #50473

Open m-natarajan opened 2 weeks ago

m-natarajan commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.46-2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @jasonli Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1728377645999889

Action Performed:

  1. SmartScan receipt with the same name as a previous duplicate
  2. See the red dot in expense
  3. Click into expense and edit merchant

Expected Result:

Duplicate flag disappear

Actual Result:

See that the duplicate flag remains

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/user-attachments/assets/f3f5bdfc-6ec6-4108-b036-d4eb2fbfcff8

https://github.com/user-attachments/assets/2dad2015-0817-4fd8-87cb-93bd32b2782f

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021844741371771684057
  • Upwork Job ID: 1844741371771684057
  • Last Price Increase: 2024-10-25
Issue OwnerCurrent Issue Owner: @hoangzinh
melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 2 weeks ago

Job added to Upwork: https://www.upwork.com/jobs/~021844741371771684057

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

abekkala commented 2 weeks ago

@RachCHopkins I'm going ooo until Oct 20. Adding another BZ member until I return, then I can take it back.

STATUS: waiting on proposals for fix

melvin-bot[bot] commented 1 week ago

@hoangzinh, @abekkala, @RachCHopkins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

RachCHopkins commented 1 week ago

Pending proposals.

hoangzinh commented 1 week ago

Waiting proposals

huult commented 1 week ago

This is a backend issue. transactionViolations_ does not update its values after themerchant is updated and remains unchanged even when I set it to [] or null in optimisticData.

hoangzinh commented 1 week ago

Hi @huult, are you using fake receipts? If yes are you able to share it here? I'm unable to reproduce this duplicated bug. Thanks in advance

Screenshot 2024-10-18 at 11 01 57

huult commented 1 week ago

@hoangzinh , Sorry, I just removed the fake receipt I used to test this ticket yesterday. You can find a fake receipt on Google and look for one that can be scanned to retrieve the Merchant. Only receipts with a scannable Merchant can reproduce this issue. I will send it to you if I am able to find it.

melvin-bot[bot] commented 1 week ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

abekkala commented 5 days ago

I'm back from ooo - unassigning @RachCHopkins

melvin-bot[bot] commented 4 days ago

@hoangzinh @abekkala this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

hoangzinh commented 3 days ago

Finally I can reproduce this issue. Agree that it might be a BE issue, as @huult pointed out here https://github.com/Expensify/App/issues/50473#issuecomment-2412973829. But I'm not sure how BE category an expense is duplicated, at the moment, in FE we only map duplicatedTransaction to merchant https://github.com/Expensify/App/blob/4f0ca943a51e340652885c3c1fa3dd4434b91e3f/src/hooks/useViolations.ts#L21

But I don't think it's enough, duplicatedTransaction means a whole expense details is duplicated with existing expenses, therefore it might be related to other fields, i.e Date, Amount...

@abekkala could you add an internal label to grab an internal engineer to this issue?

melvin-bot[bot] commented 1 day ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

hoangzinh commented 1 day ago

cc @abekkala on this comment https://github.com/Expensify/App/issues/50473#issuecomment-2432424638