Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.46k stars 2.81k forks source link

Expensify Card - Nothing happens after tapping on Learn more button under Settlement frequency #50496

Open IuliiaHerets opened 2 hours ago

IuliiaHerets commented 2 hours ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.46-4 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): applausetester+pso@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Expensify Card.
  3. Click Settings.
  4. Click Learn more under Settlement frequency.

Expected Result:

Learn more button should redirect to the relevant site.

Actual Result:

Nothing happens after tapping on Learn more button.

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/fb6b8a3d-5dd9-4e47-9cc3-2a4880691f60

View all open jobs on GitHub

melvin-bot[bot] commented 2 hours ago

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

IuliiaHerets commented 2 hours ago

We think that this bug might be related to #wave-collect - Release 2

IuliiaHerets commented 2 hours ago

@garrettmknight FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

ChavdaSachin commented 47 minutes ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Nothing happens after tapping on Learn more button under Settlement frequency

What is the root cause of that problem?

We haven't added redirect link here. https://github.com/Expensify/App/blob/3777223374152bb83333674e06b3497aaea27b81/src/pages/workspace/expensifyCard/WorkspaceCardSettingsPage.tsx#L73-L77

What changes do you think we should make in order to solve the problem?

Add appropriate link here. https://github.com/Expensify/App/blob/3777223374152bb83333674e06b3497aaea27b81/src/pages/workspace/expensifyCard/WorkspaceCardSettingsPage.tsx#L73-L77

We should store link in CONSTS.ts page and link it here

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.