Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.48k stars 2.83k forks source link

[HOLD for payment 2024-10-24] Tags - Long pressing North+east not showing settings option #50555

Open IuliiaHerets opened 1 week ago

IuliiaHerets commented 1 week ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.47-1 Reproducible in staging?: Y Reproducible in production?: N Issue reported by: Applause Internal Team

Action Performed:

  1. Launch app
  2. In old dot, upload dependent tags
  3. In new dot, open workspace settings
  4. Open tags
  5. Tap region
  6. Long press North+east

Expected Result:

Pressing "select" after long pressing the North+east tag triggers selection mode.

Actual Result:

Pressing "select" after long pressing the North+east tag doesn't trigger selection mode.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug66302711728534159671!Dependent-_Multi_Level_tags_NEW.csv

https://github.com/user-attachments/assets/3e4a4640-a54e-4db2-955a-0ee80bec4b74

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @greg-schroeder
melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 1 week ago

💬 A slack conversation has been started in #expensify-open-source

github-actions[bot] commented 1 week ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
mjasikowski commented 1 week ago

Checking this one out right now

mjasikowski commented 1 week ago

@IuliiaHerets I've edited the description, as it took me a while to understand what should be happening and what's not happening.

mjasikowski commented 1 week ago

The issue is caused by https://github.com/Expensify/App/pull/49510

daledah commented 1 week ago

@mjasikowski I'll open a follow-up PR soon.

mjasikowski commented 1 week ago

Revert cherry picked to staging

daledah commented 3 days ago

@mjasikowski Here's the PR

melvin-bot[bot] commented 23 hours ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 23 hours ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.49-2 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-24. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 23 hours ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

mjasikowski commented 18 hours ago

@daledah since you have more information, can you comment in the original PR letting us know what exactly caused the issue in question?

daledah commented 18 hours ago

@mjasikowski I commented here: https://github.com/Expensify/App/pull/49510#discussion_r1804207288