search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.48k stars 2.83k forks source link

Expense-Delete and replace options displayed for receipt in archived workspace offline #50558

Open IuliiaHerets opened 1 week ago

IuliiaHerets commented 1 week ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.47-1 Reproducible in staging?: Y Reproducible in production?: Y Issue was found when executing this PR: https://github.com/Expensify/App/pull/50395 Issue reported by: Applause Internal Team

Action Performed:

  1. Open the app and log in
  2. Navigate to a workspace chat
  3. Disable internet connection
  4. Create an expense with a receipt
  5. Navigate to the list of workspaces and delete the workspace
  6. Open the archived workspace chat
  7. Select the expense > tap 3 dots

Expected Result:

The "Delete" and "Replace" options should not be present

Actual Result:

The "Delete" and "Replace" options are displayed when the workspace is deleted offline

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/ab81d261-f065-4c24-807a-176a8fecba71

View all open jobs on GitHub

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

IuliiaHerets commented 1 week ago

We think that this bug might be related to #wave-collect - Release 1

IuliiaHerets commented 1 week ago

@dylanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Krishna2323 commented 1 week ago

I will take a look very soon. It's related to my PR so we don't need proposals here.

Krishna2323 commented 4 days ago

Sorry, I completely missed this one. Will raise a PR tomorrow.

melvin-bot[bot] commented 2 days ago

@dylanexpensify Huh... This is 4 days overdue. Who can take care of this?

dylanexpensify commented 1 day ago

ongoing

melvin-bot[bot] commented 6 hours ago

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

dylanexpensify commented 6 hours ago

Hey @johncschuster! I'm heading out on parental leave so reassigning this! TY! 🙇‍♂️