[$250] Inconsistent spacing between Add rate and Settings buttons in Distance rates and Taxes page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.47-1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester+pso@applause.expensifail.com Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings
3. Go to Distance rates
4. Go to Taxes
5. Note the spacing difference between Add rate and Settings buttons on both pages

Expected Result:

The spacing between Add rate and Settings buttons should be the same on Distance rates and Taxes page

Actual Result:

The spacing between Add rate and Settings buttons is larger on Taxes than Distance rates

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/6a5836a2-810f-4cde-8296-513ea6c10eb1

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021844581573549819097
• Upwork Job ID: 1844581573549819097
• Last Price Increase: 2024-10-11

Issue Owner

Current Issue Owner: @grgia

[melvin-bot[bot]]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[etCoderDysto]

Edited by proposal-police: This proposal was edited at 2024-10-10 14:01:40 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistent spacing between Add rate and Settings buttons in Distance rates and Taxes page

What is the root cause of that problem?

On Distance Rates page we use, styles.gap2 to add margin between the buttons https://github.com/Expensify/App/blob/175af25b5ac2645a7d1f7edf87fd35e4529cd9be/src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx#L239 On Tax rates page we are using styles.mr3 https://github.com/Expensify/App/blob/175af25b5ac2645a7d1f7edf87fd35e4529cd9be/src/pages/workspace/taxes/WorkspaceTaxesPage.tsx#L228

What changes do you think we should make in order to solve the problem?

We can change styles.mr3 and styles.gap2 to matching values. Example styles.mr2and styles.gap2.

What alternative solutions did you explore? (Optional)

We can remove styles.mr3 from here and apply styles.gap2 on the parent view container here in the same way as Distance Rates page .

Note we should check for other places where those buttons are used, and apply the same change

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021844581573549819097

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

[suneox]

The alternative solution from @etCoderDysto LGTM

🎀 👀 🎀 C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot[bot]]

@suneox, @grgia, @kadiealexander Whoops! This issue is 2 days overdue. Let's get this updated quick!

[etCoderDysto]

A kind reminder for assignment 🙇🏻‍♂️

[kadiealexander]

@grgia bump on this!