Open lanitochka17 opened 5 days ago
Triggered auto assignment to @nkuoch (DeployBlockerCash
), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
💬 A slack conversation has been started in #expensify-open-source
:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
I don't think this needs to be a blocker, so removing the labels, but yes let's find someone to work on it!
Job added to Upwork: https://www.upwork.com/jobs/~021844716640793633414
Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External
)
Accounting tab appears then disappears after selecting an integration during onboarding
Right here when we complete the onboarding we set the areConnectionsEnabled
to true:
https://github.com/Expensify/App/blob/abdfb7233e040a61d1e4433e202a8b644c7455f4/src/libs/actions/Report.ts#L3647-L3677
We should remove this code https://github.com/Expensify/App/blob/abdfb7233e040a61d1e4433e202a8b644c7455f4/src/libs/actions/Report.ts#L3647-L3677
Edited by proposal-police: This proposal was edited at 2024-10-11 14:52:46 UTC.
Accounting tab appears then disappears after selecting an integration during onboarding
We only set the areConnectionsEnabled
value optimistically to true here, but then when we call the API, we only sent areConnectionsEnabled
and not the policyID
, so the BE
won't update areConnectionsEnabled
for that policy and when we get response from the api, the accounting
is disabled.
In CompleteGuidedSetupParams
pass onboardingPolicyID
as well, this makes sure we are referencing the correct policyID
.:
Note: BE
changes would also be needed to update the areConnectionsEnabled
value of the policy.
We do the same thing in enablePolicyConnections
here
Oh we forgot to send the policy id cc @nkdengineer. Please raise a PR for this since it's a regression
@marcaaron regarding https://github.com/Expensify/App/pull/49161#discussion_r1765675105, what's the param that we should use to send the policy id over?
@allroundexperts I'd like to handle this being a "regression" from https://github.com/Expensify/App/pull/49161
@marcaaron regarding https://github.com/Expensify/App/pull/49161#discussion_r1765675105, what's the param that we should use to send the policy id over?
@s77rt I will raise the PR when we confirm this. Or we can do this in the second PR of the new feature when the task translation is confirmed.
Should be policyID
.
Or we can do this in the second PR of the new feature when the task translation is confirmed.
That sounds fine to me! Let's make sure to add that QA step.
@nkuoch I will take this over as it's related to something I missed when working with these guys.
Hey this had Help Wanted
Label attached and I posted a solution here which will be used in the PR, I guess contributors are compensated in such case right @marcaaron ?
Hey @twilight294 I'd suggest bringing that up in Slack or shooting an email over to contributors@expensify.com
. Typically, when something is a regression it's the responsibility of the person who implemented the PR. I appreciate the help and can provide this document to you review. And will also say that there are always exceptions. But I can't personally provide any guarantees right now.
Thanks for responding, I will write a mail to contributors@expensify.com
to discuss more on this 😄
Not overdue. Will be fixed in next PR
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.48-0 Reproducible in staging?: Y Reproducible in production?: N/A Unable to check If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): sdjsdudsiuhi@gmail.com Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
Accounting tab will not appear and disappear
Actual Result:
Accounting tab appears then disappears
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/user-attachments/assets/ffcd907c-b369-4e3e-8b96-e855e540cf9b
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @allroundexperts