[$62.50] Android - Chat search - Unable to reach the bottom of chat list when scrolling down

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.48-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester+kh081006@applause.expensifail.com Issue reported by: Applause - Internal Team

Action Performed:

1. Launch New Expensify app
2. Go to any chat
3. Send many messages (so that the All list in Search > Chat is scrollable)
4. Go to Search > Chat
5. Scroll down the list in All tab

Expected Result:

The bottom of the chat list can be reached

Actual Result:

User is unable to reach the bottom of chat list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/e1f1e088-8106-4fbe-9757-97809b9536a5

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021844817953624508019
• Upwork Job ID: 1844817953624508019
• Last Price Increase: 2024-10-11
• Automatic offers:
• mkhutornyi | Reviewer | 104433861

Issue Owner

Current Issue Owner: @mkhutornyi

[melvin-bot[bot]]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@joekaufmanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-control

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The bottom of the chat list can't be fully shown.

What is the root cause of that problem?

We have a contentContainerStyle to the search list which adds a margin top. It's to offset the list from the page header which was added in https://github.com/Expensify/App/pull/48258. https://github.com/Expensify/App/blob/45a3a131f56c9f1e9f81d5529b7e01ede2ae3197/src/pages/Search/SearchPageBottomTab.tsx#L134

However, because we use a margin, the height of the list is reduced by the amount of the margin-top (116).

What changes do you think we should make in order to solve the problem?

Use paddingTop instead of marginTop. It will offset the top but won't reduce the visible height on the screen. https://github.com/Expensify/App/blob/2f1b6f11fbf04a0444cd95187d221aa3eae2f02c/src/styles/index.ts#L3649-L3651

[joekaufmanexpensify]

Reproduced. A very minor issue, but an issue nonetheless. I think we can fix this, but should be lower budget, as is very minor change.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021844817953624508019

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

[mkhutornyi]

@bernhardoj's proposal looks good to me. 🎀👀🎀 C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @marcochavezf, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[marcochavezf]

Thanks for the review @mkhutornyi, assigning @bernhardoj 🚀

[melvin-bot[bot]]

📣 @mkhutornyi 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[bernhardoj]

PR is ready cc: @mkhutornyi