Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.48k stars 2.84k forks source link

Add phone number to the private personal details section #50701

Open mountiny opened 1 week ago

mountiny commented 1 week ago

Problem

Discussed in this thread

Users need a phone number to issue physical Expensify cards. We ask them for the phone number in the form to ship the Expensify card, but otherwise, this phone number is not editable from NewDot. This is a problem in case they want to edit it after adding it for the Expensify card.

Solution

Let's add the phone number row to the private personal details in Settings > Account where the other private account details live:

image

I am assigning Jon to this so he can get credits for the mocks.

Next steps:

Issue OwnerCurrent Issue Owner: @mountiny
melvin-bot[bot] commented 1 week ago

Current assignee @dubielzyk-expensify is eligible for the Design assigner, not assigning anyone new.

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @twisterdotcom (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

melvin-bot[bot] commented 1 week ago

:warning: It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time :warning:

melvin-bot[bot] commented 1 week ago

Current assignee @dubielzyk-expensify is eligible for the NewFeature assigner, not assigning anyone new.

mountiny commented 1 week ago

Keeping it weekly, I will create the API command

NJ-2020 commented 6 days ago

@mountiny Just to make sure that you're open to proposals?

mountiny commented 6 days ago

@NJ-2020 No not, yet at least

NJ-2020 commented 6 days ago

Thanks

mountiny commented 6 days ago

@DylanDylann @allgandalf the new command name is UpdatePhoneNumber and it takes authToken and the phoneNumber as params

allgandalf commented 6 days ago

Cool Cool, I will start working as soon as we have the mocks