[HOLD for payment 2024-10-24] Create workspace when new user signs up via OldDot and selects the "Manage my team's expenses" option - Githubissues

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

3.49k stars 2.85k forks source link

[HOLD for payment 2024-10-24] Create workspace when new user signs up via OldDot and selects the "Manage my team's expenses" option #50758

Open marcaaron opened 1 week ago

marcaaron commented 1 week ago

cc @carlosmiceli @anmurali

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Anu Slack conversation: https://expensify.slack.com/archives/C07HPDRELLD/p1728930765707219

Action Performed:

User signs up via OldDot and selects "Manage my team's expenses"
User is redirected to NewDot
App code redirects them to the step asking them how many employees they have

Expected Result:

When they select "Manage my team's expenses" on OldDot we should create a new workspace for them.

Actual Result:

We currently only create a workspace when they select "Manage my team's expenses" on NewDot.

SOLUTION

Let's investigate moving this to the CreateAccount call that happens on the OldDot side. Strategies where we are creating the workspace via NewDot when completing a specific onboarding step are bug prone because we may move these steps around or remove them in the future.

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @sonialiap

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @sonialiap (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 1 week ago

💬 A slack conversation has been started in #expensify-open-source

melvin-bot[bot] commented 1 week ago

:warning: It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time :warning:

github-actions[bot] commented 1 week ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

marcaaron commented 1 week ago

@danieldoglas I'm working on clearing the deploy blocker here so will remove ya

melvin-bot[bot] commented 1 week ago

Current assignee @sonialiap is eligible for the Bug assigner, not assigning anyone new.

marcaaron commented 1 week ago

Removing the blocker after patching the issue temporarily. We will still need to explore creating the policy in the CreateAccount flow so leaving this open.

melvin-bot[bot] commented 1 week ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 week ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.48-2 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/50759

If no regressions arise, payment will be issued on 2024-10-22. :confetti_ball:

melvin-bot[bot] commented 1 week ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [] The PR that introduced the bug has been identified. Link to the PR:
[ ] [] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [] Determine if we should create a regression test for this bug.
[ ] [] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

marcaaron commented 1 week ago

No payment is required for this and the deploy blocker has been fixed. We should pursue the backend fix for this next.

sonialiap commented 6 days ago

@marcaaron since the deploy blocker was fixed do we want to keep this issue open for the BE fix or do we have/want a separate issue for the BE?

carlosmiceli commented 6 days ago

I think @marcaaron was saying in Slack to just leave this one open since it already has all the information we need.

marcaaron commented 6 days ago

Yes let's just use this issue please.

melvin-bot[bot] commented 5 days ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.49-2 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/50759

If no regressions arise, payment will be issued on 2024-10-24. :confetti_ball:

melvin-bot[bot] commented 5 days ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@carlosmiceli] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/Auth/pull/11953
[ ] [@carlosmiceli] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[x] [@carlosmiceli] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C07HPDRELLD/p1728930765707219 (not in bugs, but that's where the discussion occured.
[x] [@carlosmiceli] Determine if we should create a regression test for this bug.
[x] [@carlosmiceli] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

carlosmiceli commented 5 days ago

@marcaaron quick question, how should I approach the checklist above in this case? My understanding is that this PR didn't actually introduced a bug, but rather we need to build the proper logic separately, right?

marcaaron commented 5 days ago

hmm I would not prioritize the checklist personally. This is more of a "new feature" that needs to be implemented.

carlosmiceli commented 5 days ago

Yeah, that's what I thought, but wanted to check before ignoring the checklist 👍

anmurali commented 23 hours ago

We will still need to explore creating the policy in the CreateAccount flow so leaving this open.

Am I correct in my understanding that we haven't started this yet?

marcaaron commented 22 hours ago

Initially this issue was created to fix a deploy blocker (now, done). Then left open to address fixing this in the CreateAccount flow. @carlosmiceli any updates for us?

carlosmiceli commented 22 hours ago

Not yet, couldn't make time last week, but as I mentioned to Anu I think I should be able to start this at some point halfway through this week.

anmurali commented 21 hours ago

Could we track both the permanent fix for Manage expenses for a small team and Control expenses for a larger organization together here? In both cases we need to create a workspace in CreateAccount flow, right?

carlosmiceli commented 20 hours ago

Yes to the second question. I'm also fine with closing this and moving both to the new issue.