search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.48k stars 2.84k forks source link

[HOLD for payment 2024-10-25] [HOLD for payment 2024-10-24] [$250] mWeb - Room - Cursor and hashtag are not aligned in same line #50777

Open IuliiaHerets opened 4 days ago

IuliiaHerets commented 4 days ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.49-0 Reproducible in staging?: Y Reproducible in production?: Issue reported by: Applause Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/home
  2. Tap fab - start chat - room
  3. Note the room name field

Expected Result:

Cursor and hashtag must be aligned in same line

Actual Result:

Cursor and hashtag are not aligned in same line

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/794bc419-9ef7-4ba5-9443-ae92b7b8a0a1

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021846180268747195858
  • Upwork Job ID: 1846180268747195858
  • Last Price Increase: 2024-10-15
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @joekaufmanexpensify
melvin-bot[bot] commented 4 days ago

Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 4 days ago

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 4 days ago

💬 A slack conversation has been started in #expensify-open-source

github-actions[bot] commented 4 days ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
lakchote commented 4 days ago

Found the culprit, it's https://github.com/Expensify/App/pull/49896

cc @justinpersaud @tsa321 @alitoshmatov @dubielzyk-expensify

https://github.com/user-attachments/assets/ffbf0a47-e983-4941-8e51-ab47edb98ae2

Because it's an edge case that only pertains to android mWeb, I'm not going to put this a blocker.

melvin-bot[bot] commented 4 days ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

tsa321 commented 4 days ago

@lakchote I will create a PR to fix this and similar issues.

ChavdaSachin commented 4 days ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Room - Cursor and hashtag are not aligned in same line

What is the root cause of that problem?

Extra padding right here is the culprit https://github.com/Expensify/App/blob/b4b59651d38deb3d91b1fd561458fe0d4e23752c/src/styles/index.ts#L1184

What changes do you think we should make in order to solve the problem?

Remove extra padding here https://github.com/Expensify/App/blob/b4b59651d38deb3d91b1fd561458fe0d4e23752c/src/styles/index.ts#L1184

It still solves the original problem https://github.com/Expensify/App/issues/48281 while solving following new problems https://github.com/Expensify/App/issues/50777 https://github.com/Expensify/App/issues/50778

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

joekaufmanexpensify commented 4 days ago

Went ahead and assigned @tsa321 and @alitoshmatov as their original PR introduced the regression, and PR fixing is in review

melvin-bot[bot] commented 4 days ago

Job added to Upwork: https://www.upwork.com/jobs/~021846180268747195858

melvin-bot[bot] commented 4 days ago

Current assignee @alitoshmatov is eligible for the External assigner, not assigning anyone new.

melvin-bot[bot] commented 3 days ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 3 days ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.49-2 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-24. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 3 days ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

melvin-bot[bot] commented 1 day ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.50-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-25. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 1 day ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: