[$250] Removal from approval workflow whisper doesn't mark chat unread

[garrettmknight]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: N/A Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: @JmillsExpensify Slack conversation: https://expensify.slack.com/archives/C06ML6X0W9L/p1728690809841219

Action Performed:

1. Create a workspace + enable approvals
2. Invite two approvers
3. Set Appprover 1 as the approver for everyone
4. Confirm Approver 1 has access to all user workspace chats
5. Set Apprvoer 2 as approver for everyone

Expected Result:

Approver 1 should receive a whisper in their workspace chat that they've been removed from the approval workflow and workspace chat for submitters AND their workspace chat should be set to unread.

Actual Result:

Approver 1 receives a whisper in their workspace chat that they've been removed from the approval workflow and workspace chat for submitters, but the chat was not set to unread so the approver missed the notification.

Workaround:

Yeah, they'll just be confused.

Platforms:

All

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021846286835786031750
• Upwork Job ID: 1846286835786031750
• Last Price Increase: 2024-10-22

[melvin-bot[bot]]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021846286835786031750

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[JKobrynski]

Hi, I'm Julian from Callstack - expert agency - and I would like to work on this issue.

[Beamanator]

Hmm I have a feeling it could be best to do this in the backend 🤔

[kadiealexander]

@JKobrynski do you think this can be fixed from the front end?

[JKobrynski]

@kadiealexander I am going to verify this today!

[JKobrynski]

I just finished my small investigation and based on what I've found it would be difficult to fully fix it on the frontend. The report doesn't fulfill any of the if statements in getReasonAndReportActionThatRequiresAttention that would cause it to render as an unread report. What we could do is add a pendingAction field on the backend. What do you think?

CC: @Beamanator @kadiealexander

[Beamanator]

I agree it would be easier to fix in the backend - though I believe we have other ways of making a message unread, not just via pendingAction Onyx field

[JKobrynski]

That's right! I was just suggesting one of the ways this could be handled 😄

[melvin-bot[bot]]

@kadiealexander, @situchan Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[fabioh8010]

Hey 👋 Just FYI that @JKobrynski is on sick leave since yesterday and is expected to return next week.

[situchan]

Not overdue

[JKobrynski]

Hey! FYI I'm back from the sick leave, I'll continue working on this issue

[JKobrynski]

@situchan as discussed with @Beamanator it looks like this should be fixed on the backend, is there any update on that?

[kadiealexander]

Not overdue! Assigning someone to babysit this while I'm OOO for the next two weeks.

[melvin-bot[bot]]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.