search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.52k stars 2.87k forks source link

[GR Phase 2] Step 3 Business info screen (without save API call) #50899

Open madmax330 opened 2 weeks ago

madmax330 commented 2 weeks ago

Design doc section: https://docs.google.com/document/d/1Y4P7G9h0Easjcea7wyk52gKrNB9o1yTjpmJFYkrHDW4/edit?tab=t.0#bookmark=id.xfavl5zeoc0f

MrMuzyk commented 1 week ago

I am Michał from Callstack - expert contributor group. I’d like to work on this job.

MrMuzyk commented 1 week ago

Update on my end. For now I've created draft PR. I'm expecting to create proper PR tomorrow. There might be some conflicts appearing soon. Apart from that I need to rebase it, test on all platforms and gather recordings.

MrMuzyk commented 6 days ago

Taking longer than expected due to complex situation with forms and various selectors. I've simplified logic of our brand new component that we added in previous PR (PushRowWithModal) and replaced usage of StateSelector.

State/Country selectors need to be looked at as a lot of it can be simplified. We have a few components that do the same thing in different ways. I will try have a look at it after we're done with this feature.