search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.48k stars 2.83k forks source link

Attachment - Extra space between download and close button #50993

Open IuliiaHerets opened 2 hours ago

IuliiaHerets commented 2 hours ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.50-0 Reproducible in staging?: Y Reproducible in production?: N Email or phone of affected tester (no customers): applausetester+kh081006@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Open a report.
  3. Send an image.
  4. Click on the image.

Expected Result:

There will be no extra space between download and close button.

Actual Result:

There is extra space between download and close button.

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/c046744c-1d2f-4a1a-9f24-b0511f4a8673

View all open jobs on GitHub

melvin-bot[bot] commented 2 hours ago

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 2 hours ago

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 2 hours ago

💬 A slack conversation has been started in #expensify-open-source

github-actions[bot] commented 2 hours ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
mkzie2 commented 1 hour ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is extra space between download and close button.

What is the root cause of that problem?

We added gap4 in https://github.com/Expensify/App/pull/49984:

https://github.com/Expensify/App/blob/c4f70882f836269bf2fedb6f448e20e87db1315b/src/components/HeaderWithBackButton/index.tsx#L194

What changes do you think we should make in order to solve the problem?

This was added to loosen the distance between the action buttons and search icon in this case: https://github.com/Expensify/App/pull/49984#issuecomment-2402702147.

Screenshot 2024-10-17 at 16 42 05

Remove the gap4 style. Instead add margin to the Search icon instead.

https://github.com/Expensify/App/blob/c4f70882f836269bf2fedb6f448e20e87db1315b/src/components/HeaderWithBackButton/index.tsx#L266

rayane-djouah commented 1 hour ago

@Expensify/design, could you confirm whether this is a bug or not?