search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.48k stars 2.83k forks source link

Book travel - Search icon is present on Company address RHP #51009

Open IuliiaHerets opened 2 hours ago

IuliiaHerets commented 2 hours ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.50-0 Reproducible in staging?: Y Reproducible in production?: N/A - new feature, doesn't exist in prod Email or phone of affected tester (no customers): applausetester+kh081006@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  1. Go to staging.new.expensify.com
  2. Go to FAB > Book travel.
  3. Click Book travel.

Expected Result:

Search icon will not show up on Company address RHP (because this icon is not seen on any RHP across the app, except report RHP in Search).

Actual Result:

Search icon is present on Company address RHP,

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/d09b3cfe-41b7-4459-92f1-f8008fbb2283

View all open jobs on GitHub

melvin-bot[bot] commented 2 hours ago

Triggered auto assignment to @johnmlee101 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 2 hours ago

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

github-actions[bot] commented 2 hours ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
melvin-bot[bot] commented 2 hours ago

💬 A slack conversation has been started in #expensify-open-source

abzokhattab commented 1 hour ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search icon is present on Company address RHP

What is the root cause of that problem?

The search icon is displayed in the companies address RHP component because the shouldDisplaySearchRouter is enabled inside the AddressPage which is used by the company RHP https://github.com/Expensify/App/blob/d11bfe1b44648142987117fda3e219a42b58d3d9/src/pages/AddressPage.tsx#L88

What changes do you think we should make in order to solve the problem?

we should remove shouldDisplaySearchRouter

What alternative solutions did you explore? (Optional)

rayane-djouah commented 1 hour ago

This was caused by https://github.com/Expensify/App/pull/49379 cc @Kicu @luacmartins @ikevin127