Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.52k stars 2.87k forks source link

[$250] mWeb - Expense - Second WS member can´t access report and receipt of distance split expenses #51022

Open lanitochka17 opened 2 weeks ago

lanitochka17 commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.50-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5092497&group_by=cases:section_id&group_order=asc&group_id=229067 Issue reported by: Applause - Internal Team

Action Performed:

  1. Open the staging.new.expensify.com website
  2. Open a workspace chat with at least two members
  3. Tap on the "+" button
  4. Tap on "Split Expense" and go to distance option
  5. Add start and stop waypoints
  6. Submit the expense
  7. Verify the user can open the expense report and receipt
  8. Log out from the account
  9. Log in with the account of the second workspace member
  10. Open the workspace chat
  11. Verify the second member can access the expense report and receipt

Expected Result:

Second expense participant, should be able to open the expense report and the receipt from the workspace chat

Actual Result:

When the second participant, opens the distance expense receipt, a "403 Forbidden" message is displayed, and when the report is opened, a "Hmmm, it´s not here" screen is displayed. Second Participant is not able to access the distance split expense information

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/18c87262-7101-4ec2-a7de-063a320f5d38

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021848259328541792445
  • Upwork Job ID: 1848259328541792445
  • Last Price Increase: 2024-10-28
Issue OwnerCurrent Issue Owner: @deetergp
melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 commented 2 weeks ago

@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 commented 2 weeks ago

We think that this bug might be related to #wave-collect - Release 1

melvin-bot[bot] commented 2 weeks ago

Job added to Upwork: https://www.upwork.com/jobs/~021848259328541792445

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

VickyStash commented 2 weeks ago

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

VickyStash commented 2 weeks ago

I was able to reproduce the issue, but it looks like an API problem. The app just displays what API returns.

So for the User A - the owner of the workspace and the creator of the split expense - the expense report is returned for OpenApp / OpenReport API command.

For User B - the member of the workspace - the expense report is not returned by the API inside OpenReport data. OpenReport call returns Report not found error.

NOTE : the issue is fixed if I turn User B into Admin of the workspace.

API calls User A (the one who created the split expense) User B (second member of the workspace)
OpenApp 2 01
OpenReport 3 02
Receipt display image 04
VickyStash commented 1 week ago

@ikevin127 What do you think about this?

ikevin127 commented 1 week ago

@VickyStash Thanks for the detailed explanation! Your analysis indicates that this is BE related indeed, so I'm going to auto-assign a CME to look into it and confirm whether this should be Internal.

cc @deetergp

🎀👀🎀 C+ reviewed

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @deetergp, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

kadiealexander commented 1 week ago

Reassigning to someone else to babysit this while I'm OOO for the next two weeks.

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

deetergp commented 1 week ago

I am not able to recreate this. I've tried splitting distance expenses both in and out of workspace chats and in each case, I am able to see both the expenses and the receipts as either user.

melvin-bot[bot] commented 1 week ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

joekaufmanexpensify commented 1 week ago

I can try and triage today too.

joekaufmanexpensify commented 1 week ago

@deetergp were you specifically on Android mobile web when you tried? I tried there just now and was able to reproduce with the steps in OP.

2024-10-28_18-06-12
deetergp commented 1 week ago

Oh, is it specific to Android mobile web? I am pretty sure I tried it in macOS web. I'm heading OOO for the next week—back on the 5th—if we need to keep the press going on this, you may want to find another internal engineer.

joekaufmanexpensify commented 1 week ago

I tested on android mobile web because that was in OP of the issue. This is a pretty niche case, so I don't think it's really a rush to fix it, so I think fine to leave it a week. We could also just close, but it does feel like this could come up eventually, so maybe best to fix if it's an easy PR.

joekaufmanexpensify commented 1 week ago

I'll just set to weekly for now, and we can pick this back up next week

melvin-bot[bot] commented 4 days ago

@deetergp @joekaufmanexpensify @ikevin127 @kadiealexander this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

joekaufmanexpensify commented 1 day ago

We'll pick this back up this week once Scott's back