[HOLD for payment 2024-11-11] [$250] Search - "Saved" text in search has a slight delay after deleting the term

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.50-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:N/A If this was caught during regression testing, add the test name, ID and link from TestRail:N/A Email or phone of affected tester (no customers): applausetester+en@applause.expensifail.com Issue reported by: Applause - Internal Team

Action Performed:

1. Access staging.new.expensify.com
2. Sign into a valid account
3. Tap "Search" at the bottom > Apply a Filter > Save the filter
4. Delete the Saved filter by click on the 3 dot menu > Delete
5. Observe the "Saved" text

Expected Result:

User expects that when the filter is deleted, the text disappears immediately

Actual Result:

The "Saved" text still appears for a couple of seconds after the filter was deleted

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Standalone
• [ ] Android: HybridApp
• [ ] Android: mWeb Chrome
• [ ] iOS: Standalone
• [ ] iOS: HybridApp
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/9b5f448b-2f25-4d23-a664-7c78976e9704

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021849069011992742790
• Upwork Job ID: 1849069011992742790
• Last Price Increase: 2024-10-23
• Automatic offers:
• dukenv0307 | Reviewer | 104578163
• daledah | Contributor | 104578164

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot[bot]]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-control

[Krishna2323]

Proposal


Please re-state the problem that we are trying to solve in this issue.

Search - "Saved" text in search has a slight delay after deleting the term

What is the root cause of that problem?

When checking for the saved search length we are not filtering saved search with pending action delete. https://github.com/Expensify/App/blob/62302d5cacb2ff307b2e3a2bfc267a858a79bb4d/src/pages/Search/SearchTypeMenu.tsx#L261

What changes do you think we should make in order to solve the problem?


Filtering out saved search with pending action delete and then calculate the length.

const hasVisibleSavedSearch = !!Object.values(savedSearches ?? {}).filter((s) => s.pendingAction !== 'delete').length;

NOTE: We need to do the same in SearchTypeMenuNarrow.

What alternative solutions did you explore? (Optional)

Result

[daledah]

Edited by proposal-police: This proposal was edited at 2024-10-17 14:42:39 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The "Saved" text still appears for a couple of seconds after the filter was deleted

What is the root cause of that problem?

We don't filter out the pending action

https://github.com/Expensify/App/blob/62302d5cacb2ff307b2e3a2bfc267a858a79bb4d/src/pages/Search/SearchTypeMenu.tsx#L261

What changes do you think we should make in order to solve the problem?

We should filter out the pending action if users are in online mode

    const {isOffline} = useNetwork();
const shouldShow = Object.values(savedSearches ?? {}).filter((s) => s.pendingAction !== 'delete' || isOffline).length > 0;

What alternative solutions did you explore? (Optional)

NA

[melvin-bot[bot]]

@sonialiap Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021849069011992742790

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[dukenv0307]

@daledah's proposal LGTM

🎀👀🎀 C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @dangrous, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[dangrous]

yep that looks good!

[melvin-bot[bot]]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[melvin-bot[bot]]

📣 @daledah 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[daledah]

@dukenv0307 PR is ready.

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.56-9 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/51549

If no regressions arise, payment will be issued on 2024-11-11. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @dukenv0307 requires payment automatic offer (Reviewer)
• @daledah requires payment automatic offer (Contributor)

[melvin-bot[bot]]

@dukenv0307 @sonialiap The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[sonialiap]

Payment summary: @dukenv0307 $250 upwork - please complete the checklist (fun new form if you have the K2 extension haha) @daledah $250 upwork

[dukenv0307]

BugZero Checklist:

• [x] [Contributor] Classify the bug:

Bug classification

Source of bug: - [ ] 1a. Result of the original design (eg. a case wasn't considered) - [x] 1b. Mistake during implementation - [ ] 1c. Backend bug - [ ] 1z. Other: Where bug was reported: - [x] 2a. Reported on production - [ ] 2b. Reported on staging (deploy blocker) - [ ] 2c. Reported on a PR - [ ] 2z. Other: Who reported the bug: - [ ] 3a. Expensify user - [ ] 3b. Expensify employee - [ ] 3c. Contributor - [x] 3d. QA - [ ] 3z. Other:

• [x] [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/48566/files#r1829096619

• [x] [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [x] [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

Regression Test Proposal Template

• [x] [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue: https://github.com/Expensify/Expensify/issues/443368

Regression Test Proposal

Test:

1. Create a saved search
2. Delete the search filter
3. Verify that: "Saved" text dissapears immediately.

Do we agree 👍 or 👎

[dukenv0307]

@sonialiap I completed the checklist

[sonialiap]

Payments completed