Open danielrvidal opened 1 week ago
Triggered auto assignment to @zanyrenney (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
Job added to Upwork: https://www.upwork.com/jobs/~021847081858608334041
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External
)
Edited by proposal-police: This proposal was edited at 2024-10-18 01:11:24 UTC.
SelfDM is marked as unread even though there is no message
We forced showing unread for empty self DM:
Remove the isSelfDM
check from the above.
I'm dropping the price on this as a one-liner we've identified.
Upwork job price has been updated to $125
@zanyrenney when this is deployed, please make sure we remove this test case from QA: https://github.com/Expensify/Expensify/issues/412760
CC: @isagoico
@zanyrenney, @mkhutornyi Whoops! This issue is 2 days overdue. Let's get this updated quick!
@mkzie2's proposal looks good. 🎀👀🎀 C+ reviewed
Triggered auto assignment to @bondydaa, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
📣 @mkhutornyi 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!
📣 @mkzie2 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻 Keep in mind: Code of Conduct | Contributing 📖
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
Reviewing
label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.53-1 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-11-01. :confetti_ball:
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Confirmed it's working on production as intended!
BUG: SelfDM is marked as unread even though there is no message
We discussed this internally and can't think of any cases where the SelfDM should be unread. So let's please update the flow so that it is marked as read when users come in as new users.
Some background from @trjExpensify: https://github.com/Expensify/App/pull/43489 - It looks like we did this in this PR.
We need to remove the selfDM from this line: https://github.com/Expensify/App/blob/f180cbb97f7158ee6339215c9d5313b50f232c8c/src/libs/ReportUtils.ts#L6127
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @zanyrenney