Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.49k stars 2.84k forks source link

Search - Down caret icon and search icon are close to each other #51077

Open IuliiaHerets opened 3 days ago

IuliiaHerets commented 3 days ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.50-4 Reproducible in staging?: Y Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y Email or phone of affected tester (no customers): applausetester+zm37@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

  1. Launch New Expensify app.
  2. Go to FAB > Start chat.
  3. Select a user with long name.
  4. Submit an expense to the user.
  5. Make sure that user name and expense amount are long enough to reach the search icon on the expense report header.
  6. Go to expense report.

Expected Result:

There will be spacing between the down caret and search icon on the expense report header.

Actual Result:

The down caret and search icon are very close to each other.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6638169_1729198209607!IMG_5549

https://github.com/user-attachments/assets/80f0fe63-4c57-4bf5-b7e7-cfd090a82da3

View all open jobs on GitHub

melvin-bot[bot] commented 3 days ago

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 3 days ago

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 3 days ago

💬 A slack conversation has been started in #expensify-open-source

github-actions[bot] commented 3 days ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
SzymczakJ commented 3 days ago

This is a small visual bug and I don't think it deserves a Deploy Blocker label. @luacmartins I'd like to fix it since I implemented Search 2.4.

MonilBhavsar commented 3 days ago

Thank you! Agree, this is not really a blocker. I will assign you to this issue

MonilBhavsar commented 3 days ago

Assigning @rayane-djouah as a C+ following the main PR

Kicu commented 3 days ago

Will provide a fix for this, please assign me

Kicu commented 3 days ago

fix in PR ready to check