[HOLD for payment 2024-11-05] [$250] Update LHN nav items to be 52px tall instead of 56px tall

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.50-8 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @shawnborton Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1729242925493769

Action Performed:

1. Go to staging.new.expensify.com
2. Click search
3. Observe navigation items

   Expected Result:

   All the navigation items are updated to use the correct height so we stay consistent with 52px for big buttons

   Actual Result:

   Currently our LHN nav items for pages like Search, Settings, Workspace Editor, etc use a height of 56px.

   Workaround:

   Unknown

   Platforms:

   Which of our officially supported platforms is this issue occurring on?

   • [ ] Android: Standalone
   • [ ] Android: HybridApp
   • [ ] Android: mWeb Chrome
   • [ ] iOS: Standalone
   • [ ] iOS: HybridApp
   • [ ] iOS: mWeb Safari
   • [x] MacOS: Chrome / Safari
   • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

 

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021847349783902749913
• Upwork Job ID: 1847349783902749913
• Last Price Increase: 2024-10-18

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot[bot]]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[jayeshmangwani]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The LHN navigation items (MenuItem) need to have a height of 52px instead of 56px.

What is the root cause of that problem?

This is a straightforward enhancement.

What changes do you think we should make in order to solve the problem?

We just need to update the sectionMenuItem height from 56px to 52px, which will resolve the issue for Workspaces and Settings and Search nav for web. https://github.com/Expensify/App/blob/219707fd932242de5ed1d5dc4a63967df007be11/src/styles/index.ts#L2892-L2895

Screenshots showing how the 52px height will look are provided below.

Web/Desktop

Settings

Workspace

Search

iOS

Settings

 

Workspace

 

What alternative solutions did you explore? (Optional)

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021847349783902749913

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[s77rt]

@jayeshmangwani Thanks for the proposal.

However, to fix this height for Search, we also need to handle the FocusableMenuItem

Can you please elaborate what part of the Search page this is needed for?

[jayeshmangwani]

@s77rt If you inspect the Dropdown menu item height on mobile, you’ll notice it's set to 64px instead of 56px. On the web, the height works fine(56px).

To address this issue on mobile, I suggest passing the wrapperStyle prop. The wrapperStyle should be:

wrapperStyle={{
    alignItems: 'center',
    height: styles.sectionMenuItem.height
}}

https://github.com/Expensify/App/blob/66cf824036a51183d73dab2cc621901e43fe3196/src/components/FocusableMenuItem.tsx#L14-L17

[s77rt]

Ah the popover, no I think that should remain untouched

[jayeshmangwani]

I think it should be 56px (after fixing this issue, it should be 52px), as the same option on the web currently has a height of 56px.

[jayeshmangwani]

Or, we could adjust the height of the menu item specifically for the Search dropdown here.

[s77rt]

We need to change the height only for the LHN items. On small screens we will render the popover menu, nothing to change there

[jayeshmangwani]

Alright, I'll go ahead and remove that part from the proposal.

[s77rt]

🎀 👀 🎀 C+ reviewed Link to proposal

[melvin-bot[bot]]

Triggered auto assignment to @rafecolton, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[rafecolton]

@shawnborton can you please clarify if the popover height should change too?

@jayeshmangwani I'm assigning you, but let's wait to get this merged until we get clarification from Shawn if the popover is in scope too

[rafecolton]

Removing and re-adding to try to re-trigger the upwork automation

[jayeshmangwani]

@rafecolton Upwork automation might not trigger here because both s77rt and I will be paid via NewDot

[shawnborton]

No need to change the popover option row item height, let's first just start with the LHN items. Thanks!

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.54-11 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/51169

If no regressions arise, payment will be issued on 2024-11-05. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment through NewDot Manual Requests
• @jayeshmangwani requires payment through NewDot Manual Requests

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@s77rt / @jayeshmangwani] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@s77rt / @jayeshmangwani] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@s77rt / @jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@s77rt / @jayeshmangwani] Determine if we should create a regression test for this bug.
• [ ] [@s77rt / @jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

Checklist ^ does not apply. Not a bug

[slafortune]

@s77rt Role C+ requires payment through NewDot Manual Requests - Due $250 @jayeshmangwani Role Contributor requires payment through NewDot Manual Requests - Due $250

[JmillsExpensify]

$250 approved for @s77rt

[garrettmknight]

$250 approved for @jayeshmangwani