search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.48k stars 2.84k forks source link

2FA - When open the link to 'Authenticator app link' the page shows an error #51095

Open lanitochka17 opened 2 days ago

lanitochka17 commented 2 days ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.50 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): aatweq+33333334@gmail.com Issue reported by: Applause - Internal Team

Action Performed:

  1. Loggin
  2. Click on 'Settings'
  3. Click on 'Security'
  4. Click on 'Two-factor authentication'
  5. Click on 'Copy' and click on 'Next' green button
  6. Click on 'authenticator app link'

Expected Result:

The user should be able to see the website

Actual Result:

When the user click on 'authenticator app link' the redirected website throws an error

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/29f04271-d8ba-4b0a-a9c3-418d90ee0695

View all open jobs on GitHub

melvin-bot[bot] commented 2 days ago

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 commented 2 days ago

@lschurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

NJ-2020 commented 2 days ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

We need to update this link to the correct one inside help.expensify.com https://github.com/Expensify/App/blob/f7d08e0941b9747bf266a11264bbf47f51bafda6/src/pages/settings/Security/TwoFactorAuth/Steps/VerifyStep.tsx#L25 https://github.com/Expensify/App/blob/f7d08e0941b9747bf266a11264bbf47f51bafda6/src/pages/settings/Security/TwoFactorAuth/Steps/VerifyStep.tsx#L87

What changes do you think we should make in order to solve the problem?

We need to update the link to: https://help.expensify.com/articles/new-expensify/settings/Enable-Two-Factor-Authentication

And we need to confirm the above link to Expensify team

What alternative solutions did you explore? (Optional)

truph01 commented 2 days ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

When the user click on 'authenticator app link' the redirected website throws an error

What is the root cause of that problem?

https://github.com/Expensify/App/blob/66cf824036a51183d73dab2cc621901e43fe3196/docs/redirects.csv#L502

but because of the additional path /p1?new=1, app does not handle redirect properly.

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)