search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.48k stars 2.84k forks source link

Cannot submit survey and open Expensify Classic after pressing the “Enter” key. #51145

Open m-natarajan opened 3 hours ago

m-natarajan commented 3 hours ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9..0.51-1 Reproducible in staging?: y Reproducible in production?: y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @suneox Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1729337665245359

Action Performed:

  1. Open the profile and switch to Expensify Classic.
  2. Select a reason and press Enter.
  3. Type a response and press Enter.
  4. Press Enter to submit the response.

    Expected Result:

    The response should be submitted and open Expensify Classic.

Actual Result:

Nothing happens at the "exit survey" step when the Enter key is pressed.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence https://github.com/user-attachments/assets/28cfebb6-ecdd-481c-bff0-b27aba19c750

View all open jobs on GitHub

melvin-bot[bot] commented 3 hours ago

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

nkdengineer commented 3 hours ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Cannot submit survey and open Expensify Classic after pressing the “Enter” key.

What is the root cause of that problem?

We don't pass props pressOnEnter in this button

What changes do you think we should make in order to solve the problem?

We should add props pressOnEnter as true in this button

What alternative solutions did you explore? (Optional)

NA

jliexpensify commented 3 hours ago

@m-natarajan can you attach the video please?

suneox commented 1 hour ago

https://github.com/user-attachments/assets/acca42b4-881d-46dc-b869-527a879835db

@jliexpensify I’ve reported this issue and have more context on it, so I can assist with reviewing the proposal as a C+.

melvin-bot[bot] commented 1 hour ago

Job added to Upwork: https://www.upwork.com/jobs/~021848188969730042061

jliexpensify commented 1 hour ago

Thanks, have assigend you as I can reproduce.

melvin-bot[bot] commented 1 hour ago

Current assignee @suneox is eligible for the External assigner, not assigning anyone new.