search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.56k stars 2.9k forks source link

Ensure phoneNumber is returned in the personalDetails #51170

Open mountiny opened 3 weeks ago

mountiny commented 3 weeks ago

Found during reviewing https://github.com/Expensify/App/pull/50660#issuecomment-2426153748 when the personal details are added the phoneNumber was not returned as part of the personalDetails response

Investigate why and and make sure its returned

melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

DylanDylann commented 3 weeks ago

@mountiny

phoneNumber isn't returned caused this bug

RCA:

https://github.com/Expensify/App/blob/d329b9ce9005bef129bb45562db98770744dfec8/src/components/ReportActionItem/IssueCardMessage.tsx#L30-L36

missingDetails is true because there are no phoneNumber

--> The add missing detail button appear

https://github.com/Expensify/App/blob/d329b9ce9005bef129bb45562db98770744dfec8/src/components/ReportActionItem/IssueCardMessage.tsx#L45-L51

kadiealexander commented 3 weeks ago

Not overdue.

melvin-bot[bot] commented 2 weeks ago

@mountiny, @kadiealexander Huh... This is 4 days overdue. Who can take care of this?

mountiny commented 2 weeks ago

frontend changes merged, I need to make another small change in the be to make sure the phoneNumber is returned as part of the user personalDetails in OpenApp

melvin-bot[bot] commented 1 week ago

@mountiny @kadiealexander this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] commented 1 week ago

@mountiny, @kadiealexander Huh... This is 4 days overdue. Who can take care of this?

mountiny commented 1 week ago

havent got around yet

mountiny commented 5 days ago

On my list

mountiny commented 3 days ago

Auth PR raised https://github.com/Expensify/Auth/pull/13129

mountiny commented 3 days ago

web PR to clean up the Params also raised

mountiny commented 2 days ago

After the auth deploy we can merge the web change too