Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.49k stars 2.84k forks source link

Search - Search does not returns group when entering group members #51175

Closed IuliiaHerets closed 4 hours ago

IuliiaHerets commented 7 hours ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.51-2 Reproducible in staging?: Y Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5107189&group_by=cases:section_id&group_order=asc&group_id=229066 Email or phone of affected tester (no customers): gocemate+a2595@gmail.com Issue reported by: Applause Internal Team

Action Performed:

  1. Create group chat and invite two users (for example bob@domain.com, and alice@domain.com)
  2. Go to chat search and enter member's emails ( bob@domain.com and alice@domain.com)

Expected Result:

The search should displays the group

Actual Result:

Search does not returns group when entering group members

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/c4891981-f200-446f-9746-92c3b025b5a2

View all open jobs on GitHub

melvin-bot[bot] commented 7 hours ago

Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 7 hours ago

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 7 hours ago

💬 A slack conversation has been started in #expensify-open-source

github-actions[bot] commented 7 hours ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
mjasikowski commented 7 hours ago

checking

mjasikowski commented 5 hours ago

caused by https://github.com/Expensify/App/pull/48652 according to git bisect

mjasikowski commented 5 hours ago

Revert in progress

mjasikowski commented 5 hours ago

FYI this happens when group member names are separated by whitespace only. It works fine if you enter the names separated by comma and a space (like they are in the group chat title), but nevertheless - this is a bug.