search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.49k stars 2.84k forks source link

Search - Unable to delete expense when there is message in the combined report #51194

Open IuliiaHerets opened 5 hours ago

IuliiaHerets commented 5 hours ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.51-2 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): applausetester+kh081006@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to FAB > Submit expense > Manual.
  3. Submit an expense to a user that has no unsettled expense.
  4. Go to Search.
  5. Click on the expense.
  6. Send a message.
  7. Close the report RHP.
  8. Select the expense via checkbox.
  9. Click on the dropdown > Delete.
  10. Delete the expense.
  11. Click on the expense.
  12. Repeat Step 1 to 10 but do not add a message to the combined report (exclude Step 5 to 7).

Expected Result:

The expense will be deleted.

Actual Result:

The expense cannot be deleted on Search page when there is message in the combined report.

This issue is not reproducible when the combined report has no message (Step 12).

This issue is not the same as https://github.com/Expensify/App/issues/43415 because in this issue, the expense is not deleted at all.

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/45c11c0c-3a5e-4e64-a165-e2fec4b6bef5

View all open jobs on GitHub

melvin-bot[bot] commented 5 hours ago

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

IuliiaHerets commented 5 hours ago

We think that this bug might be related to #wave-control

IuliiaHerets commented 5 hours ago

@adelekennedy FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors