Open zsgreenwald opened 5 days ago
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External
)
Edited by proposal-police: This proposal was edited at 2024-10-22 02:23:15 UTC.
Update the Onboarding steps for "Chat and split bills with friends"
Changes Request
We need update the splitExpense
here
{
type: 'splitExpense',
autoCompleted: false,
title: 'Split an expense',
description:
'*Split an expense* right in your chat with one or more friends.\n' +
'\n' +
'Here’s how to request money:\n' +
'\n' +
'1. Hit the green *+* button.\n' +
'2. Choose *Start chat*.\n' +
'3. Enter any email, SMS, or name of who you want to split with.\n' +
'4. From within the chat, hit the *+* button on the message bar, and hit *Split expense*.\n' +
'5. Create the expense by selecting Manual, Scan or Distance.\n' +
'\n' +
'Feel free to add more details if you want, or just send it off. Let’s get you paid back!',
},
RESULT
Edited by proposal-police: This proposal was edited at 2024-10-22 05:50:49 UTC.
Update the Onboarding steps for "Chat and split bills with friends"
General Update
I propose to include this task with Spanish translation, and translate all the other onboarding tasks to Spanish as well(could be handled as separate PR if needed). Something like....
{
type: 'splitExpense',
autoCompleted: false,
title: Translate('onboarding.tasks.splitExpense.title'),
description:
Translate('onboarding.tasks.splitExpense.description'),
},
Add this to en.ts here
tasks: {
splitExpense: {
title: 'Split an expense',
description:
'*Split an expense* right in your chat with one or more friends.\n' +
'\n' +
'Here’s how to request money:\n' +
'\n' +
'1. Hit the green *+* button.\n' +
'2. Choose *Start chat*.\n' +
'3. Enter any email, SMS, or name of who you want to split with.\n' +
'4. From within the chat, hit the *+* button on the message bar, and hit *Split expense*.\n' +
'5. Create the expense by selecting Manual, Scan or Distance.\n' +
'\n' +
'Feel free to add more details if you want, or just send it off. Let’s get you paid back!',
}
}
and update es.ts accordingly.
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Triggered auto assignment to @danielrvidal (Waiting for copy
), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.
@danielrvidal , added Waiting for copy
for 👀 on copy in the OP.
@ikevin127 are you doing the work here as the contributor or will you be reviewing proposals and the PR?
I assigned myself as BZ since I was tagged and have context
@mallenexpensify I will be taking over as C+ reviewing the proposals. While we're waiting for confirmation on copy, I will start reviewing the proposals.
Current assignee @mallenexpensify is eligible for the Bug assigner, not assigning anyone new.
⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.
One more thing @ikevin127 this looks like a simple text update so I set it at $125. Let me know if I'm missing something
Given that there's no mention about translations in the OP, the codebase shows no indication of translating any of the ONBOARDING_MESSAGES
as we keep them in CONST instead of translation files, I'd say let's go with @nyomanjyotisa's proposal as this is a simple copy replacement task.
I think moving / translating all ONBOARDING_MESSAGES
would be out of scope for this issue. @ChavdaSachin if you want to do that you'd have a better chance in this issue, so I'd recommend you to post a proposal there.
🎀👀🎀 C+ reviewed
Triggered auto assignment to @nkuoch, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
The copy looks good in the proposals. I was going to note Split expense should be bolded in #4 but it looks like the proposals account for that. I'm unassigning myself but please add me back if needed.
@nkuoch , plz review @nyomanjyotisa 's proposal above , thx
Problem
The steps presented currently expose dated functionality and that isn't available in-app anymore. This causes user-confusion for anyone that selects that onboarding intent.
Solution
Update the onboarding steps for the Task -
Split an expense
to:Split an expense right in your chat with one or more friends.
Here’s how to request money:
Feel free to add more details if you want, or just send it off. Let’s get you paid back!
cc: @mallenexpensify @vitHoracek as we'll be tapping C+ for this
Issue Owner
Current Issue Owner: @ikevin127