Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.5k stars 2.85k forks source link

[$125] Update the Onboarding steps for "Chat and split bills with friends" #51215

Open zsgreenwald opened 5 days ago

zsgreenwald commented 5 days ago

Problem

The steps presented currently expose dated functionality and that isn't available in-app anymore. This causes user-confusion for anyone that selects that onboarding intent.

image

Solution

Update the onboarding steps for the Task - Split an expense to:

Split an expense right in your chat with one or more friends.

Here’s how to request money:

  1. Hit the green + button
  2. Choose "Start chat"
  3. Enter any email, SMS, or name of who you want to split with
  4. From within the chat, hit the + button on the message bar, and hit Split expense
  5. Create the expense by selecting Manual, Scan or Distance

Feel free to add more details if you want, or just send it off. Let’s get you paid back!

cc: @mallenexpensify @vitHoracek as we'll be tapping C+ for this

Issue OwnerCurrent Issue Owner: @ikevin127
melvin-bot[bot] commented 5 days ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

nyomanjyotisa commented 5 days ago

Edited by proposal-police: This proposal was edited at 2024-10-22 02:23:15 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update the Onboarding steps for "Chat and split bills with friends"

What is the root cause of that problem?

Changes Request

What changes do you think we should make in order to solve the problem?

We need update the splitExpense here

                {
                    type: 'splitExpense',
                    autoCompleted: false,
                    title: 'Split an expense',
                    description:
                        '*Split an expense* right in your chat with one or more friends.\n' +
                        '\n' +
                        'Here’s how to request money:\n' +
                        '\n' +
                        '1. Hit the green *+* button.\n' +
                        '2. Choose *Start chat*.\n' +
                        '3. Enter any email, SMS, or name of who you want to split with.\n' +
                        '4. From within the chat, hit the *+* button on the message bar, and hit *Split expense*.\n' +
                        '5. Create the expense by selecting Manual, Scan or Distance.\n' +
                        '\n' +
                        'Feel free to add more details if you want, or just send it off. Let’s get you paid back!',
                },

RESULT

Screenshot 2024-10-22 at 10 47 45

What alternative solutions did you explore? (Optional)

ChavdaSachin commented 4 days ago

Edited by proposal-police: This proposal was edited at 2024-10-22 05:50:49 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update the Onboarding steps for "Chat and split bills with friends"

What is the root cause of that problem?

General Update

What changes do you think we should make in order to solve the problem?

I propose to include this task with Spanish translation, and translate all the other onboarding tasks to Spanish as well(could be handled as separate PR if needed). Something like....

                {
                    type: 'splitExpense',
                    autoCompleted: false,
                    title: Translate('onboarding.tasks.splitExpense.title'),
                    description:
                        Translate('onboarding.tasks.splitExpense.description'),
                },

https://github.com/Expensify/App/blob/04214cdb3e35816fd28a640f1b3c1b23bd7407b0/src/CONST.ts#L4819-L4834

Add this to en.ts here

tasks: {
     splitExpense: {
          title: 'Split an expense',
          description: 
                 '*Split an expense* right in your chat with one or more friends.\n' +
                        '\n' +
                        'Here’s how to request money:\n' +
                        '\n' +
                        '1. Hit the green *+* button.\n' +
                        '2. Choose *Start chat*.\n' +
                        '3. Enter any email, SMS, or name of who you want to split with.\n' +
                        '4. From within the chat, hit the *+* button on the message bar, and hit *Split expense*.\n' +
                        '5. Create the expense by selecting Manual, Scan or Distance.\n' +
                        '\n' +
                        'Feel free to add more details if you want, or just send it off. Let’s get you paid back!',
          }
}

and update es.ts accordingly.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

melvin-bot[bot] commented 4 days ago

Triggered auto assignment to @danielrvidal (Waiting for copy), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.

mallenexpensify commented 4 days ago

@danielrvidal , added Waiting for copy for 👀 on copy in the OP.
@ikevin127 are you doing the work here as the contributor or will you be reviewing proposals and the PR?

I assigned myself as BZ since I was tagged and have context

ikevin127 commented 4 days ago

@mallenexpensify I will be taking over as C+ reviewing the proposals. While we're waiting for confirmation on copy, I will start reviewing the proposals.

melvin-bot[bot] commented 4 days ago

Current assignee @mallenexpensify is eligible for the Bug assigner, not assigning anyone new.

melvin-bot[bot] commented 4 days ago

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

mallenexpensify commented 4 days ago

One more thing @ikevin127 this looks like a simple text update so I set it at $125. Let me know if I'm missing something

ikevin127 commented 4 days ago

Given that there's no mention about translations in the OP, the codebase shows no indication of translating any of the ONBOARDING_MESSAGES as we keep them in CONST instead of translation files, I'd say let's go with @nyomanjyotisa's proposal as this is a simple copy replacement task.

I think moving / translating all ONBOARDING_MESSAGES would be out of scope for this issue. @ChavdaSachin if you want to do that you'd have a better chance in this issue, so I'd recommend you to post a proposal there.

🎀👀🎀 C+ reviewed

melvin-bot[bot] commented 4 days ago

Triggered auto assignment to @nkuoch, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

danielrvidal commented 3 days ago

The copy looks good in the proposals. I was going to note Split expense should be bolded in #4 but it looks like the proposals account for that. I'm unassigning myself but please add me back if needed.

mallenexpensify commented 1 day ago

@nkuoch , plz review @nyomanjyotisa 's proposal above , thx