Open IuliiaHerets opened 5 days ago
Triggered auto assignment to @zanyrenney (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Edited by proposal-police: This proposal was edited at 2024-10-25 00:25:20 UTC.
Chat - Invalid welcome text when opening a conversation with a new user
Changes Request
We need to update the reportActionsView
on here and here
reportActionsView: {
....
beginningOfChatHistory: 'This is the beginning of your chat with ',
...
usePlusButton: ({additionalText}: UsePlusButtonParams) => `\nYou can also use the + button to ${additionalText}!`,
askConcierge: '\nAsk questions and get 24/7 realtime support.',
iouTypes: {
pay: 'pay',
split: 'split',
submit: 'submit',
track: 'track',
invoice: 'invoice',
},
anExpense: 'an expense',
assignTask: 'assign a task',
},
and update the additionalText
on here
const additionalText = `${filteredOptions.map((item) => `${translate(`reportActionsView.iouTypes.${item}`)} ${translate('reportActionsView.anExpense')}`).join(', ')} ${translate(
'common.or',
)} ${translate('reportActionsView.assignTask')}`;
},
RESULT
Or just update the reportActionsView
to
reportActionsView: {
...
beginningOfChatHistory: 'This is the beginning of your chat with ',
...
usePlusButton: ({additionalText}: UsePlusButtonParams) => `\nYou can also use the + button to ${additionalText}, or assign a task!`,
askConcierge: '\nAsk questions and get 24/7 realtime support.',
iouTypes: {
pay: 'pay expenses',
split: 'split an expense',
submit: 'submit an expense',
track: 'track an expense',
invoice: 'invoice an expense',
},
},
and update the additionalText
const additionalText = filteredOptions.map((item) => translate(`reportActionsView.iouTypes.${item}`)).join(', ');
The welcome text is expected here
Well done for forgetting the expected welcome text.
Job added to Upwork: https://www.upwork.com/jobs/~021849547431797589961
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External
)
49592
Hmmm Yes Looks like this text is expected
@zanyrenney Could you please check this issue ?
And we can close this issue or update the text otherwise
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.52-1 Reproducible in staging?: Y Reproducible in production?: Y Issue was found when executing this PR: https://github.com/Expensify/App/pull/49592 Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
Welcome should be "Say hello! This is the beginning of your chat with username. You can also use the + button to slip an expense, submin an expense, pay expenses, or assign a task!"
Actual Result:
Welcome text is "Say hello! This chat is with username. Use the + button to split, submit, or pay an expense."
Workaround:
Unknown
Platforms:
Screenshots/Videos
https://github.com/user-attachments/assets/2dc72162-2100-4615-a3c0-9a4bcafe5757
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @ZhenjaHorbach