Open IuliiaHerets opened 21 hours ago
Triggered auto assignment to @OfstadC (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
Triggered auto assignment to @pecanoro (DeployBlockerCash
), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
💬 A slack conversation has been started in #expensify-open-source
:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
The RHP is not dismissed when clicking outside it for the first time. It returns to copilot confirmation page.
We only hide the modal when it's closed
We should dismiss the modal if we click outside. We can add onBackdropPress
to Modal
here.
onBackdropPress={() => {
Navigation.dismissModal();
}}
OPTIONAL: We can introduce a new prop onBackdropPress
in ValidateCodeActionModal
and add onBackdropPress
here that will dismiss the modal here and other places that use ValidateCodeActionModal
and want to dismiss the modal if clicking outside.
Since this is under a beta, I am going to remove the blocker first
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.52-2 Reproducible in staging?: Y Reproducible in production?: N Email or phone of affected tester (no customers): applausetester+kh081006@applause.expensifail.com Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
The RHP will be dismissed when clicking outside it for the first time (production behavior).
Actual Result:
The RHP is not dismissed when clicking outside it for the first time. It returns to copilot confirmation page.
Workaround:
Unknown
Platforms:
Screenshots/Videos
https://github.com/user-attachments/assets/f1f8540d-f066-4bcf-ab49-22278b208943
View all open jobs on GitHub