Expense - Error when submitting distance expense to non-existing workspace chat

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.52-2 Reproducible in staging?: Y Reproducible in production?: N If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester+kh1610015@applause.expensifail.com Issue reported by: Applause - Internal Team

Action Performed:

1. Go to OD
2. Create a new Control workspace
3. Go to ND
4. Go to FAB > Submit expense > Distance
5. Enter waypoints > Next
6. Select the Control workspace chat created on OD
7. On confirmation page, click Rate
8. Note that Rate list is empty
9. Submit the distance expense
10. Go to transaction thread

Expected Result:

In Step 8, Rate list should not be empty In Step 10, the distance expense will be submitted without issue

Actual Result:

In Step 8, Rate list is empty In Step 10, error happens when submitting distance expense to non-existing workspace chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Standalone
• [ ] Android: HybridApp
• [x] Android: mWeb Chrome
• [x] iOS: Standalone
• [ ] iOS: HybridApp
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/0adbcc4f-c74e-44fb-a044-0bf4ae481e98

View all open jobs on GitHub

[melvin-bot[bot]]

Triggered auto assignment to @blimpich (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot[bot]]

💬 A slack conversation has been started in #expensify-open-source

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@blimpich FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-control

[blimpich]

Probably related to https://github.com/Expensify/App/pull/49412, checking locally if reverting it fixes this.

[blimpich]

Reverting does seem to fix the issue, discussing possible solutions other than reverting in Slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1729624660433179?thread_ts=1729612151.981119&cid=C01GTK53T8Q

[blimpich]

Decided to revert, working on that now.

[blimpich]

Steps still needed:

• [x] merge revert PR to main
• [x] confirm CP request goes through and code is CP'ed to staging
• [x] ask QA to re-test this deploy blocker
• [ ] remove deploy blocker / close issue
• [ ] check deploy blocker off the deploy checklist

[blimpich]

Will be afk for 1.5 hours, will continue steps above once I'm back