Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.49k stars 2.85k forks source link

[$250] Brief loading circle when accessing Company Cards page #51333

Open joekaufmanexpensify opened 3 hours ago

joekaufmanexpensify commented 3 hours ago

Problem

(Discussed here) every time you access the Company cards empty-state page on the workspace, there's a brief loading circle while we render the graphic in the middle of the page. This makes the experience feel less premium, as there isn't any significant amount of data being loaded here. It also doesn't exist for the Expensify Card empty state, which is analogous to this page.

Company cards page

https://github.com/user-attachments/assets/e5cb423e-5fc7-4ec9-a763-1fc4523378e4

Expensify Card page

https://github.com/user-attachments/assets/192b40bb-6a4c-4a9b-a677-9a511aa1326d

Solution

Remove this loading indicator when accessing Company cards. If we don't need it when accessing Expensify Card empty state, it shouldn't be necessary here either, as they're essentially the same page with a different graphic.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021849080892463168395
  • Upwork Job ID: 1849080892463168395
  • Last Price Increase: 2024-10-23
Issue OwnerCurrent Issue Owner: @getusha
melvin-bot[bot] commented 3 hours ago

Triggered auto assignment to @Christinadobrzyn (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

melvin-bot[bot] commented 3 hours ago

:warning: It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time :warning:

melvin-bot[bot] commented 3 hours ago

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

joekaufmanexpensify commented 3 hours ago

@waterim is taking this one. Once they comment here, we'll assign them!

joekaufmanexpensify commented 3 hours ago

@shawnborton IDT there are really any design implications to this one, as it's just polish for the loading of this page. But LMK if anything comes to mind!

waterim commented 3 hours ago

Hello Im Artem from Callstack and would like to take this one!

melvin-bot[bot] commented 3 hours ago

Job added to Upwork: https://www.upwork.com/jobs/~021849080892463168395

melvin-bot[bot] commented 3 hours ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)