Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.57k stars 2.91k forks source link

[HOLD] SearchForReports query doesn't sort results #51343

Open m-natarajan opened 1 month ago

m-natarajan commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.52-5 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @JmillsExpensify Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1729007631513779

Action Performed:

  1. Go to staging.new.expensify.com
  2. Click Search on LHN
  3. Click chat > Search icon
  4. Enter workspace name in search field

    Expected Result:

    Search result sorted as expected (1.Order everything by the last message timestamp (descending) 2.When searching, self DM is put at the top 3.All archived reports should remain at the bottom)

    Actual Result:

    The workspace chat is not displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence ![CleanShot 2024-10-15 at 17 51 57](https://github.com/user-attachments/assets/f4006ff0-fa4e-4da7-907b-b4787ba860d8) https://github.com/user-attachments/assets/83c5fb3e-4e2f-4f05-80c2-05202610c2bb

View all open jobs on GitHub

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @flodnv (AutoAssignerNewDotQuality)

muttmuure commented 4 weeks ago

@JmillsExpensify is this a CRITICAL #quality project?

alexpensify commented 4 weeks ago

@JmillsExpensify should this be an Internal or External GH? Thanks!

flodnv commented 4 weeks ago

Internal.

flodnv commented 4 weeks ago

I am a bit confused by the expected result @JmillsExpensify

  1. Order everything by the last message timestamp (descending)
  2. When searching, self DM is put at the top
  3. All archived reports should remain at the bottom

Is this saying that this should be the order of things, assuming they are present in the results? Like:

  1. Workspace chat
  2. self dm
  3. archived reports

? How does last message timestamp affect this? Like what if the last message in the self dm was 1 hour ago, and the last message in the workspace chat was 2 hours ago?

alexpensify commented 3 weeks ago

It's not overdue; we are waiting for feedback here.

JmillsExpensify commented 3 weeks ago

This should be on hold. It needs to go through the design process internally first. I'll also take it over.

JmillsExpensify commented 3 weeks ago

P.S. @luacmartins is going to take the lead on this one!

luacmartins commented 2 weeks ago

Posted whatsnext proposal. Gonna ship a pre-design by EOD tomorrow.

luacmartins commented 2 weeks ago

Tracking issue here

melvin-bot[bot] commented 1 week ago

@luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick!

luacmartins commented 1 week ago

I'll work on the HL doc this week

melvin-bot[bot] commented 4 days ago

@luacmartins Huh... This is 4 days overdue. Who can take care of this?

luacmartins commented 3 days ago

I still need to write the HL