Open IuliiaHerets opened 2 days ago
Triggered auto assignment to @lakchote (DeployBlockerCash
), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
Triggered auto assignment to @adelekennedy (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
💬 A slack conversation has been started in #expensify-open-source
:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Not a blocker, it concerns an issue with Debug
mode. It also concerns Web as a whole.
Job added to Upwork: https://www.upwork.com/jobs/~021849364084876247061
Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External
)
mWeb - Debug - In workspace chat, delete via debug directs to blank page.
We use Navigation.goBack(); after the delete action https://github.com/Expensify/App/blob/45cabbfd877234921be4439a7c9c922f6a45a581/src/pages/Debug/DebugDetails.tsx#L233-L241
Use Navigation.dismissModal(); instead
Edited by proposal-police: This proposal was edited at 2024-10-24 12:34:01 UTC.
mWeb - Debug - In workspace chat, delete via debug directs to blank page
When clicking the delete the report, we only navigating back from the report which will only dismiss the modal https://github.com/Expensify/App/blob/45cabbfd877234921be4439a7c9c922f6a45a581/src/pages/Debug/DebugDetails.tsx#L237-L240
We need to add the Navigation.dismissModal(); too And we will run the goBack function if it's small screen width
Navigation.dismissModal();
if (isSmallScreenWidth) {
Navigation.isNavigationReady().then(() => {
Navigation.goBack();
})
}
https://github.com/user-attachments/assets/2ab0ff2d-12f9-49c6-859d-9e28dc42fb65
After deleting report from debug page, a blank page is shown.
When we press delete, it will delete the report and go back to the previous page. The previous page in our case is the report details page. The report details page is wrapped with a withReportOrNotFound
HOC. In the HOC, if shouldShowNotFoundPage
is true (because the report is empty) and contentShown
ref is true, we render nothing.
https://github.com/Expensify/App/blob/bb4e3e45586aa63e027972da29ebc125b56ea05e/src/pages/home/report/withReportOrNotFound.tsx#L86-L90
The comment mentions why we do that. Basically, if the report is previously available but now is not, we assume that the page will be dismissed along with the deletion and we don't want to show not found page while navigating back. However, that is not the case when we delete it from the debug page.
Also, that's not the case if say:
Because we don't want to show the not found briefly when navigating back, we can check for the screen focused state instead. https://github.com/Expensify/App/blob/bb4e3e45586aa63e027972da29ebc125b56ea05e/src/pages/home/report/withReportOrNotFound.tsx#L86-L90
if (shouldShowNotFoundPage && !isFocused) {
return null;
}
@alitoshmatov please review proposals, thank you.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.53-0 Reproducible in staging?: Y Reproducible in production?: Unable to check in Prod, Debug mode is not available Issue reported by: Applause Internal Team
Action Performed:
Pre-condition: 1.Go to https://staging.new.expensify.com/home
Go to profile icon -- troubleshoot
Scroll down to enable debug mode
Go to https://staging.new.expensify.com/home
Tap on a workspace chat
Send a message
Tap header -- debug
Scroll down to tap delete
Note a blank page displayed
Refresh the page
Note hmm not here page displayed
Navigate to LHN
Note report disappeared from LHN
Expected Result:
In workspace chat, delete via debug must not direct to blank page.
Actual Result:
In workspace chat, delete via debug directs to blank page initially and on refresh directs to hmm not here. Then navigating to LHN, particular report is not shown.
Workaround:
Unknown
Platforms:
Screenshots/Videos
https://github.com/user-attachments/assets/02014ea0-2158-4623-b9ca-eea79799b3f7
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @alitoshmatov