search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.5k stars 2.85k forks source link

Android -Unable to change workspace currency on first try when tapping while keyboard is up #51389

Open IuliiaHerets opened 3 days ago

IuliiaHerets commented 3 days ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.53-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y Issue was found when executing this PR: https://github.com/Expensify/App/pull/51173 Email or phone of affected tester (no customers): nathanmulugetatesting+1936@gmail.com Issue reported by: Applause Internal Team

Action Performed:

  1. Open newDot hybrid app
  2. Create a workspace
  3. Go to workspace profile settings
  4. Open workspace currency
  5. Search for other currency for e.g "EUR"
  6. Tap on the EUR currency while keyboard is up

Expected Result:

The currency gets selected and app navigates back to workspace profile settings page

Actual Result:

The currency does not get selected on first trial, user has to tap on the currency multiple of times

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/7a3c72d1-11ee-4881-b61e-c778a1e5a58c

View all open jobs on GitHub

melvin-bot[bot] commented 3 days ago

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

ChavdaSachin commented 3 days ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android -Unable to change workspace currency on first try when tapping while keyboard is up

What is the root cause of that problem?

We do not dismiss keyboard on WorkspaceProfileCurrencyPage as we do on IOURequestStepCurrency https://github.com/Expensify/App/blob/8e13bcc227cbc330b80bdfdb6bd6c87b232dd6d1/src/pages/workspace/WorkspaceProfileCurrencyPage.tsx#L21-L24

https://github.com/Expensify/App/blob/8e13bcc227cbc330b80bdfdb6bd6c87b232dd6d1/src/pages/iou/request/step/IOURequestStepCurrency.tsx#L57-L64

What changes do you think we should make in order to solve the problem?

Add Keyboard.dismiss(); here https://github.com/Expensify/App/blob/8e13bcc227cbc330b80bdfdb6bd6c87b232dd6d1/src/pages/workspace/WorkspaceProfileCurrencyPage.tsx#L21-L24

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Christinadobrzyn commented 2 days ago

Hybrid app so this needs to go through Internal to see if we want to fix it. Reaching out to the team to see if we can make this external since it's affecting another app.

https://expensify.slack.com/archives/C06ML6X0W9L/p1729837653095419?thread_ts=1729833606.671219&cid=C06ML6X0W9L