Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.57k stars 2.91k forks source link

[Snyk] Security upgrade electron from 29.4.6 to 31.7.2 #51400

Open melvin-bot[bot] opened 4 weeks ago

melvin-bot[bot] commented 4 weeks ago

snyk-top-banner

Snyk has created this PR to fix 13 vulnerabilities in the npm dependencies of this project.

Snyk changed the following file(s):

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Out-of-bounds Read
SNYK-JS-ELECTRON-8302877
  ****  
medium severity Type Confusion
SNYK-JS-ELECTRON-8302879
  ****  
high severity Use After Free
SNYK-JS-ELECTRON-8302881
  ****  
high severity External Control of Assumed-Immutable Web Parameter
SNYK-JS-ELECTRON-8302883
  ****  
high severity Heap-based Buffer Overflow
SNYK-JS-ELECTRON-8302885
  ****  
high severity Use After Free
SNYK-JS-ELECTRON-8302887
  ****  
critical severity Out-of-Bounds Write
SNYK-JS-ELECTRON-8302889
  ****  
high severity Type Confusion
SNYK-JS-ELECTRON-8302891
  ****  
high severity Heap-based Buffer Overflow
SNYK-JS-ELECTRON-8302893
  ****  
high severity Heap-based Buffer Overflow
SNYK-JS-ELECTRON-8302895
  ****  
medium severity Heap-based Buffer Overflow
SNYK-JS-ELECTRON-8302897
  ****  
medium severity Heap-based Buffer Overflow
SNYK-JS-ELECTRON-8302899
  ****  
high severity Out-of-bounds Read
SNYK-JS-ELECTRON-8230426
  421  

[!IMPORTANT]

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information: 🧐 View latest project report 📜 Customise PR templates 🛠 Adjust project settings 📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Type Confusion 🦉 Use After Free

melvin-bot[bot] commented 4 weeks ago

This is a Snyk issue. Snyk is a tool that automatically tracks our repositories' dependencies and reports associated security vulnerabilities. It also automatically create PRs to fix these vulnerabilities.

    C+: Please follow these steps to test the linked PR before running through the reviewer checklist:
    - [ ] The first step is to understand the PR: what dependency is it upgrading, for which vulnerability, how it impacts our product & end users.
    - [ ] If the issue is not worth fixing, please add your reasoning in the issue and have the internal engineer review it.
    - [ ] Check the change log (which should be included in the PR description) to see all changes. We want to identify any breaking changes. If it is a minor version bump, it's unlikely that there are any breaking changes.
    - [ ] Test our feature(s) that make use of this package. If it does not work, we should understand what broke it. It is also a good idea to check our main flows to make sure they are not broken that you can add in the checklist screenshots/videos.
melvin-bot[bot] commented 4 days ago

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!